From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C0A7A0579; Wed, 18 Mar 2020 10:45:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 52DFE1AFF; Wed, 18 Mar 2020 10:45:21 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 761ACFEB for <dev@dpdk.org>; Wed, 18 Mar 2020 10:45:19 +0100 (CET) IronPort-SDR: huXOn3q+N2NVSJirUU3/Hbx8hr2KTpdVamv+mtemuZDoqAThCXMQay2aWBltNAm7ksmUK9SumG +Pl32+fwEO3g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 02:45:18 -0700 IronPort-SDR: Leq8ShlnTEXBTkigVZQJWRX6vFFuAfoJmoQ7B8H9XabKGjY1bhObOgqMRiLUehvogZJpQaJJQG 2lQ3EIrMTMGA== X-IronPort-AV: E=Sophos;i="5.70,566,1574150400"; d="scan'208";a="444108759" Received: from bricha3-mobl.ger.corp.intel.com ([10.251.165.47]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 18 Mar 2020 02:45:16 -0700 Date: Wed, 18 Mar 2020 09:45:11 +0000 From: Bruce Richardson <bruce.richardson@intel.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org, aconole@redhat.com, ruifeng.wang@arm.com, david.marchand@redhat.com Message-ID: <20200318094511.GB1491@bricha3-MOBL.ger.corp.intel.com> References: <20200316170921.6020-1-bruce.richardson@intel.com> <3483262.VQhiAETyHQ@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3483262.VQhiAETyHQ@xps> Subject: Re: [dpdk-dev] [RFC PATCH] ci: reduce examples built for static builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Mon, Mar 16, 2020 at 07:37:01PM +0100, Thomas Monjalon wrote: > 16/03/2020 18:09, Bruce Richardson: > > Static builds can take a lot of space, so reduce the number of examples > > built when doing those static builds. > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> > > --- > > --- a/.ci/linux-build.sh > > +++ b/.ci/linux-build.sh > > +if [ "$DEF_LIB" = "static" ] ; then > > + OPTS="$OPTS -Dexamples=l2fwd,l3fwd" > > +else > > + OPTS="$OPTS -Dexamples=all" > > +fi > > I was thinking about doing this kind of change in devtools/test-meson-builds.sh > What do you think? > No major objection. It's probably less likely to be an issue for people running their own test-builds, though if it saves time and space and doesn't much affect the number of issues we are going to hit/miss, I don't see why not do so.