From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] devtools: silence meson install
Date: Wed, 18 Mar 2020 10:02:45 +0000 [thread overview]
Message-ID: <20200318100245.GC1491@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20200317162521.17857-1-david.marchand@redhat.com>
On Tue, Mar 17, 2020 at 05:25:21PM +0100, David Marchand wrote:
> Installing with ninja is quite verbose by default, hide ninja output under
> TEST_MESON_BUILD_VERBOSE and TEST_MESON_BUILD_VERY_VERBOSE options.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> devtools/test-meson-builds.sh | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index c2d33b3b9f..c1ff2bb50a 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -104,8 +104,13 @@ compile () # <builddir>
> install_target () # <builddir> <installdir>
> {
> rm -rf $2
> - echo "DESTDIR=$2 $ninja_cmd -C $1 install"
> - DESTDIR=$2 $ninja_cmd -C $1 install
> + if [ -n "$TEST_MESON_BUILD_VERY_VERBOSE$TEST_MESON_BUILD_VERBOSE" ]; then
> + echo "DESTDIR=$2 $ninja_cmd -C $1 install"
> + DESTDIR=$2 $ninja_cmd -C $1 install
> + else
> + echo "DESTDIR=$2 $ninja_cmd -C $1 install >/dev/null"
> + DESTDIR=$2 $ninja_cmd -C $1 install >/dev/null
> + fi
> }
>
> build () # <directory> <target compiler> <meson options>
> --
> 2.23.0
>
next prev parent reply other threads:[~2020-03-18 10:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 16:25 David Marchand
2020-03-18 10:02 ` Bruce Richardson [this message]
2020-03-23 10:58 ` Thomas Monjalon
2020-03-23 13:20 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318100245.GC1491@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).