From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B5E1A0583; Thu, 19 Mar 2020 08:46:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D3841AFF; Thu, 19 Mar 2020 08:46:22 +0100 (CET) Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 5DD0EF94 for ; Thu, 19 Mar 2020 08:46:21 +0100 (CET) Received: by mail-lj1-f193.google.com with SMTP id o10so1300655ljc.8 for ; Thu, 19 Mar 2020 00:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NccwooGfaR8wLsV/oT0JQiX1uw+ggabfdtbap70Q57s=; b=Yb2GhxbQ+1CRC6mbgwBfmA9ENklZO/STEB2oHKnOwVxOPu+rpJxitySaICn5/E/EZW 9KBLqEFwdRMqR3WAoT8lyF/pPr1u2w3dnbfbCMH8T1IAut5io7Gqh6YWG7xYf4vkSd+h fQmn/dCWMpGcqK8EBoi6qn1YGm3cSU6WP1oIYcK1XRW1cyBOh9PNQ5PPMSLO2M+yDDOL nhYJDvkfPAIWejAGrOO5CZqyzJrNCv4KlG6Y6H+JjvNTVBTCK9KtDoj9e/KA5SzYzNzX Tw80ifEhzd7TWOY9vxw+JjcvHm4GFc/Mt1fgNrMz+6cDwaLs3VX/vJe9HqVaDs+csQvj +Dhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NccwooGfaR8wLsV/oT0JQiX1uw+ggabfdtbap70Q57s=; b=kL4Vm5ja5CoR9HRufbevxQtryc4ELI1ZdvDZmLEX4ABJcb0pa7nwPmu/pX2sqbunVt GLNRYLhip6MpaVdgA6emOcVD6UX5x1QfTADOrbittFHxWtjrcOslbDLgH6CPeUqyXgcm hIcmbGzOUBDt4BOV6Y0xCBGyupYjZX5AIkYo/aFf9KGdZv2/s9B3xb/S9Z3B82AdVbBC Tb1WhDBTWur53m1Oonyph4FANP0KPJTaPvvcF7U4E+04pVcYhKfL7Sx7WrIqhMsoZtVz RAH011fp0bCtYXvynd3lVxHKTkbbtj3o9i4UGXsIGmEvb5/0KgR21yBY4UGCmoyiIzS3 PKUA== X-Gm-Message-State: ANhLgQ2omTLnewqaWdtkBChGjYG2/lktGycxh+1qTKdUhZ109J9kzW+I Ox1dFnp13FpOlv7ilh/5645Fnw== X-Google-Smtp-Source: ADFU+vsVYU510DDd9+MgOf08KQSdwx4CNiBo54piu3QJJetAdQBv9Y2krVG2cud7+sHZfNRuiK0uPg== X-Received: by 2002:a2e:7d19:: with SMTP id y25mr1253843ljc.262.1584603980751; Thu, 19 Mar 2020 00:46:20 -0700 (PDT) Received: from localhost.localdomain ([182.191.83.208]) by smtp.gmail.com with ESMTPSA id f8sm823515ljc.86.2020.03.19.00.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 00:46:20 -0700 (PDT) From: Muhammad Ahmad To: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, ferruh.yigit@intel.com Cc: Muhammad Ahmad , dev@dpdk.org Date: Thu, 19 Mar 2020 12:44:00 +0500 Message-Id: <20200319074400.14139-1-muhammad.ahmad@emumba.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200318152227.3931-1-muhammad.ahmad@emumba.com> References: <20200318152227.3931-1-muhammad.ahmad@emumba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=y Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3] testpmd: added rte_eth_dev_fw_version_get in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" rte_eth_dev_fw_version_get() was not called in test pmd.  Added rte_eth_dev_fw_version_get() in testpmd under show port info Bugzilla ID: 225 Cc: dev@dpdk.org Reported-by: Thomas Monjalon Signed-off-by: Muhammad Ahmad --- app/test-pmd/config.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 8cf84ccd3..66f3de908 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -52,6 +52,8 @@ #include "testpmd.h" +#define ETHDEV_FWVERS_LEN 32 + static char *flowtype_to_str(uint16_t flow_type); static const struct { @@ -523,6 +525,7 @@ port_infos_display(portid_t port_id) uint16_t mtu; char name[RTE_ETH_NAME_MAX_LEN]; int ret; + char fw_version[ETHDEV_FWVERS_LEN]; if (port_id_is_invalid(port_id, ENABLED_WARN)) { print_valid_ports(); @@ -544,6 +547,13 @@ port_infos_display(portid_t port_id) rte_eth_dev_get_name_by_port(port_id, name); printf("\nDevice name: %s", name); printf("\nDriver name: %s", dev_info.driver_name); + + if (rte_eth_dev_fw_version_get(port_id, fw_version, + ETHDEV_FWVERS_LEN) == 0) + printf("\nFirmware-version: %s", fw_version); + else + printf("\nFirmware-version: %s", "not available"); + if (dev_info.device->devargs && dev_info.device->devargs->args) printf("\nDevargs: %s", dev_info.device->devargs->args); printf("\nConnect to socket: %u", port->socket_id); -- 2.17.1