From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Andy Pei <andy.pei@intel.com>
Cc: dev@dpdk.org, rosen.xu@intel.com, stable@dpdk.org,
david.marchand@redhat.com, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/ipn3ke: use ctrl thread to check link status
Date: Thu, 19 Mar 2020 21:42:44 +0800 [thread overview]
Message-ID: <20200319134243.GD51165@intel.com> (raw)
In-Reply-To: <1584338837-436345-1-git-send-email-andy.pei@intel.com>
On 03/16, Andy Pei wrote:
>ipn3ke driver creates a thread to check link status.
>
>before this patch, pthread_create() is used to create
>thread, leaving the new thread unrestrained wrt cpu
>affinity.
>
>After this patch, rte_ctrl_thread_create() is used to
>create thread. The affinity of the new thread is based
>on the CPU affinity retrieved at the time rte_eal_init()
>was called, the dataplane and service lcores are then
>excluded.
>
>Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor")
>Cc: rosen.xu@intel.com
>Cc: stable@dpdk.org
>
>Signed-off-by: Andy Pei <andy.pei@intel.com>
>---
>Cc: david.marchand@redhat.com
>Cc: xiaolong.ye@intel.com
>Cc: ferruh.yigit@intel.com
>
>diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c
>index 80122e3..b673c49 100644
>--- a/drivers/net/ipn3ke/ipn3ke_representor.c
>+++ b/drivers/net/ipn3ke/ipn3ke_representor.c
>@@ -2598,7 +2598,8 @@ struct rte_eth_xstat_name *xstats_names,
> int ret;
>
> if (ipn3ke_rpst_scan_num == 1) {
>- ret = pthread_create(&ipn3ke_rpst_scan_thread,
>+ ret = rte_ctrl_thread_create(&ipn3ke_rpst_scan_thread,
>+ "ipn3ke scanner",
> NULL,
> ipn3ke_rpst_scan_handle_request, NULL);
> if (ret) {
>--
>1.8.3.1
>
Applied to dpdk-next-net-intel, Thanks.
next prev parent reply other threads:[~2020-03-19 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 6:07 Andy Pei
2020-03-19 5:52 ` Xu, Rosen
2020-03-19 13:42 ` Ye Xiaolong [this message]
2020-03-19 14:13 ` Xu, Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319134243.GD51165@intel.com \
--to=xiaolong.ye@intel.com \
--cc=andy.pei@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).