From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86C01A0562; Tue, 31 Mar 2020 20:04:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B56081C112; Tue, 31 Mar 2020 20:04:46 +0200 (CEST) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id 90B0F1C10E for ; Tue, 31 Mar 2020 20:04:45 +0200 (CEST) Received: by mail-pj1-f66.google.com with SMTP id kx8so1394486pjb.5 for ; Tue, 31 Mar 2020 11:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=g0qFD/SMoVgzRJdu1+j9DCB+yFzcSO73Ph9Rnj2JbpM=; b=sW6TR9ZRmL/hXSlhB3zAIYvfPdHRj5+kp9PaGER9b3Rz8wrX6oatWUO2roCzcmTtCz umsGfeZSW7ZkiIDKQQhaAk+b4zCSWcu9cX0DMjDv1OOrsa/mNdJs7fSlPTYWTAL4W36Y Y3kgiyT2RACJ1Gim52H2d3Jkl9S/HcijxWN1Zsbfeup8OpGbXbw7lIx9xUvajjj/daCx TmbrrNE+GIPty31b7roBQ5/KBXsgzvIN0yNUAYaWrk4qk8b9izmQZkaUDgkgbi4f2B7I h4zC28m1kiam1ZLKGemKLfFYG0pNWwNG4pLSn/2edIkJd6wWzU/iGF8ideHCO5NALXqY Xqmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=g0qFD/SMoVgzRJdu1+j9DCB+yFzcSO73Ph9Rnj2JbpM=; b=TACnY0Daxpia3ojjvCU/8sSRnMrXmD+XI/QXgLrpCIjEtcVCouIOYyjU+oT3W2GFVZ hvBDRdaCnTe3VlAHcnT4g+djPYG3MnOGM9OFDx1GJj1ccOHhLvy+qF/zmSWk2EmlXIN2 uraxdh7LrUwJUD5zcwdgKwOyRxEJx7o85HGCbiUjOtKU5ejKH9iEO/ALvUTjUYAdSbyM AvorVage+YMQsaAcGtnTR/2PrELWYopCFdALtq4ASdJj+av8XHCnufJIElNItKav6wvn OC/Z6J6gs2znrG0hI8aG6w92QiWEDePSmntWnrhtdWHG/eg4+8VvTKJnua2OJDve92c7 wVow== X-Gm-Message-State: ANhLgQ0ZZu87cjNKb7IHSOBEx2/cpgb0nGGFNDjerGMhL8iep+v7qsVb Tru/zwqrkowCnIbNwj4q22MxDQ== X-Google-Smtp-Source: ADFU+vskrKtKuEKkYVDp5Qi4vDhebWFqwEFT21v0zT9XsAOm27EAdB8TQqHDkHB9s9um4iqQjB7+2g== X-Received: by 2002:a17:902:8492:: with SMTP id c18mr19343906plo.147.1585677884537; Tue, 31 Mar 2020 11:04:44 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q8sm2472621pjq.28.2020.03.31.11.04.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 11:04:43 -0700 (PDT) Date: Tue, 31 Mar 2020 11:04:35 -0700 From: Stephen Hemminger To: Ajit Khaparde Cc: Ferruh Yigit , Somnath Kotur , dpdk-dev , David Marchand Message-ID: <20200331110435.27507cf1@hermes.lan> In-Reply-To: References: <20200303175938.14292-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/6] net/bnxt: bounds checking patches X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 31 Mar 2020 10:52:47 -0700 Ajit Khaparde wrote: > On Tue, Mar 31, 2020 at 5:23 AM Ferruh Yigit wrote: > > > On 3/3/2020 5:59 PM, Stephen Hemminger wrote: > > > This set of patches came from security review of bnxt driver. > > > It introduces a set of overflow macros that could be more widely > > > used in other places in DPDK to check for math overflows. > > > > > > Stephen Hemminger (6): > > > eal: add portable way to check for math overflow > > > net/bnxt: fix potential data race > > > net/bnxt: avoid potential out of bounds read > > > net/bnxt: check for integer overflow in buffer sizing > > > net/bnxt: add integer underflow check > > > net/bnxt: sanitize max_l2_ctx > > > > > > > Hi Ajit, > > > > I can see this patchset has been merged into your tree, although the note > > in the > > mail list is missing. Since it has eal changes, I believe they should be > > reviewed first before merging into brcm tree, can you separate the eal and > > dependent patch for review, we can proceed with rest? > > > I don't mind. > But being original owner - Stephen, do you want to go ahead? > > Thanks > Ajit > > > > > Regards, > > ferruh > > Sure, I expected normal review cycle on this. Hoped that other drivers and eal core would also add overflow checks