From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 303FBA0562; Tue, 31 Mar 2020 19:15:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A94F01C0D7; Tue, 31 Mar 2020 19:14:34 +0200 (CEST) Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by dpdk.org (Postfix) with ESMTP id 662121C0C4 for ; Tue, 31 Mar 2020 19:14:25 +0200 (CEST) Received: by mail-pj1-f68.google.com with SMTP id kx8so1338358pjb.5 for ; Tue, 31 Mar 2020 10:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qsb7BmJUn8DCb/zClKimtajfedrzR8g6JTYpx34OQV8=; b=Ce0R9p8NXHNziC0lwvvyQl3m0x5GsPEVGiWrzDPpsMPSMufCN7m3zFUHZ3wr+/dZVE pBY9Upt5zCpQAWDJiKutOMpdXH9W0wbABq2tXlGn7oAAIBGsAXFjrUpa1EiqD57xLNDD eN0c/vHZLCc9Fsm6Z1UmSj5NRU8Dg1xU4my68XwKd3SL+9qUBBHshAP7yA9+F4h9wJQz iWx9B7pCvaLzDGGrNoU2Vj1Z3HBo+mrqvXuDtiyDxN+ZSpRBZGb8ZnSrrdn//fPQo7PP F2k+4YWU6aai0o7ggvFG1DXHUwIyf+pC/3LZgZuGSTcJbWYhtxgZd6KTgtb/q6swKJC0 0VOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qsb7BmJUn8DCb/zClKimtajfedrzR8g6JTYpx34OQV8=; b=YesXABZZm7137GWvF1bYG05Dx1IxyEVWL1FxJAuAJfmlZnvwc+FJMHN717IAsO6KwO Xo3Yduy7lZjjEFM5byavIKeOlJSUcTeqIDZ2Dqt6FqpKN2I9VM1/AFq/7oftY9fUoBb6 dNhRrg1eDuMuMrlWB8Sl7jyQWDttXk1i4CBJA8qDUbBSfXQOS+9krmiHyl84OxipqSD/ uhOqKcghPR5STDSRrc6tZklR1OMnt4UUHxpYjpuL4jTdBe2lSNET/phIdI86gORdQwDA XGrYvZD39asKedfXvymMO3Cmv3cBSB998IHz6AOz5WZnQpdHOkrQoE2tzL+hEOp9XNBA Gzng== X-Gm-Message-State: ANhLgQ26m8EdCTUM35HEzf8ypue7f7OPLYB7Hrib+k8G0cJ52rVZrgZ4 Sybvot/cH10mUMp4px6n+f2kktn87gYsew== X-Google-Smtp-Source: ADFU+vudVUJUoUzJsyPimHLqp2KOi3AwxZsAhNkO6m5z0agZxSOGWstDiTXlzWQ1v/VNuYTHOc4KCA== X-Received: by 2002:a17:902:9a03:: with SMTP id v3mr17829493plp.272.1585674863647; Tue, 31 Mar 2020 10:14:23 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id i124sm12869764pfg.14.2020.03.31.10.14.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 10:14:21 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , stable@dpdk.org Date: Tue, 31 Mar 2020 10:14:01 -0700 Message-Id: <20200331171404.23596-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331171404.23596-1-stephen@networkplumber.org> References: <20200316235612.29854-1-stephen@networkplumber.org> <20200331171404.23596-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4 5/8] net/netvsc: remove process event optimization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove unlocked check for data in receive ring. This check is not safe because of missing barriers etc. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxtx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index 32c03e3da0c7..e8df84604202 100644 --- a/drivers/net/netvsc/hn_rxtx.c +++ b/drivers/net/netvsc/hn_rxtx.c @@ -969,10 +969,6 @@ uint32_t hn_process_events(struct hn_data *hv, uint16_t queue_id, rxq = queue_id == 0 ? hv->primary : dev->data->rx_queues[queue_id]; - /* If no pending data then nothing to do */ - if (rte_vmbus_chan_rx_empty(rxq->chan)) - return 0; - /* * Since channel is shared between Rx and TX queue need to have a lock * since DPDK does not force same CPU to be used for Rx/Tx. -- 2.20.1