From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FE76A0562; Tue, 31 Mar 2020 19:31:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 676BC1C0C6; Tue, 31 Mar 2020 19:31:26 +0200 (CEST) Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) by dpdk.org (Postfix) with ESMTP id 8EE551C0BE for ; Tue, 31 Mar 2020 19:31:23 +0200 (CEST) Received: by mail-pj1-f65.google.com with SMTP id jz1so1165790pjb.0 for ; Tue, 31 Mar 2020 10:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MsYKPhlOawbFQs+xEOzXBIqaNoVvXo+uTGLPRaNTWZA=; b=DN3b2F3j2FrVkqjdV+NWzHcBB/rvATmIF94xc8FVYUN5WbyNFpXo32WovkX7OHUxqv bMYu2JLKuYoUSlmgsNv5COUBvlJmOZk4xRATJNv27uCQCGzWX3oc+9RbZHTZF9CaNfZu sdW6CBqy1fmU2jG17cLh1mQGAXg41f14CKM8Kg5jqYgfRCGEYoRBrUtUIGGOxXL1WsaQ Llmb/qWVFvrjAZk2J+i36zbBZkgs+rqHFvbkwDDQxUS8MxXlBCBahtJmnbPnD9ro2hao CJOjL6HuDBwrUaywYnjR4vCJt49ANEUcbcNDC/e9HlyXLSPbtp2iK0l96arHdPFPNlc1 aWgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MsYKPhlOawbFQs+xEOzXBIqaNoVvXo+uTGLPRaNTWZA=; b=BTVymjaT/Vt35fp1WcBXlpPm9VKx+n6PTORbLnv5AN5Ug4HLUgV4oFo0rF/zfJnSPl UMgb2yhV7ghsWQQitczzqu6ThW64FR3O19PHyh2fy7UaAc9iFDz29GcaSpT9cXdBe2cI 4yzlm30vYNHIoz0qHpW2X+PCjfsMBoJDQm79tCV02SRtMGtm8B0SQ73ACkI1kq5wM7Fl nw28J9CzjG5nMvIRH7lqIT++2ztA0E1DhvjlGOsdqD6RglqwaGMeC+s5s2iTUyXl7JSk G4hvilAcPrAL8MPrX8CBti96Af1dAIY3JXams4+8r+md/Vmd7nSGbxuvHkyua2h3VkVr xcuw== X-Gm-Message-State: AGi0PuZAMSdvWoWglABR2g6h08Iq3JD0ZWf/v6v/1gNbJXY6NnoemG/L IeAPOdVEdoVBCHb4oNK28WvF1P17zBI1Kg== X-Google-Smtp-Source: APiQypLbGsZgbjnyrHiQsJqNNA1ILH8vxLc1EWxcofBVbHt5t9MpJa1DCjoBvPh/8v4h0BoyVMSvcA== X-Received: by 2002:a17:90a:4d43:: with SMTP id l3mr5093109pjh.165.1585675882282; Tue, 31 Mar 2020 10:31:22 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 198sm12999261pfa.87.2020.03.31.10.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 10:31:21 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 31 Mar 2020 10:31:05 -0700 Message-Id: <20200331173110.25746-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331173110.25746-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> <20200331173110.25746-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 2/7] net/virtio: do not use PMD logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Virtio driver has its own logtype adn should not use legacy PMD logtype. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_rxtx.c | 6 +++--- drivers/net/virtio/virtio_user_ethdev.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index 752faa0f6e7e..060410577af4 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_rxtx.c @@ -1085,7 +1085,7 @@ virtio_dev_tx_queue_setup(struct rte_eth_dev *dev, RTE_MIN(vq->vq_nentries / 4, DEFAULT_TX_FREE_THRESH); if (tx_free_thresh >= (vq->vq_nentries - 3)) { - RTE_LOG(ERR, PMD, "tx_free_thresh must be less than the " + PMD_DRV_LOG(ERR, "tx_free_thresh must be less than the " "number of TX entries minus 3 (%u)." " (tx_free_thresh=%u port=%u queue=%u)\n", vq->vq_nentries - 3, @@ -1133,7 +1133,7 @@ virtio_discard_rxbuf(struct virtqueue *vq, struct rte_mbuf *m) error = virtqueue_enqueue_recv_refill(vq, &m, 1); if (unlikely(error)) { - RTE_LOG(ERR, PMD, "cannot requeue discarded mbuf"); + PMD_DRV_LOG(ERR, "cannot requeue discarded mbuf"); rte_pktmbuf_free(m); } } @@ -1145,7 +1145,7 @@ virtio_discard_rxbuf_inorder(struct virtqueue *vq, struct rte_mbuf *m) error = virtqueue_enqueue_refill_inorder(vq, &m, 1); if (unlikely(error)) { - RTE_LOG(ERR, PMD, "cannot requeue discarded mbuf"); + PMD_DRV_LOG(ERR, "cannot requeue discarded mbuf"); rte_pktmbuf_free(m); } } diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c index e61af4068322..5637001dfccb 100644 --- a/drivers/net/virtio/virtio_user_ethdev.c +++ b/drivers/net/virtio/virtio_user_ethdev.c @@ -561,7 +561,7 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev) const char *name = rte_vdev_device_name(dev); eth_dev = rte_eth_dev_attach_secondary(name); if (!eth_dev) { - RTE_LOG(ERR, PMD, "Failed to probe %s\n", name); + PMD_INIT_LOG(ERR, "Failed to probe %s", name); return -1; } -- 2.20.1