From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DF88A0562; Tue, 31 Mar 2020 19:31:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2577C1C0CE; Tue, 31 Mar 2020 19:31:29 +0200 (CEST) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by dpdk.org (Postfix) with ESMTP id EE9EA1C0B7 for ; Tue, 31 Mar 2020 19:31:24 +0200 (CEST) Received: by mail-pf1-f195.google.com with SMTP id a24so3800294pfc.8 for ; Tue, 31 Mar 2020 10:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4STHvn45VW3tSwuQaAkxb8w0CsvHEqi7ZK830XrKDMg=; b=ZJwbn61Uf3OFTqMMZjrCD5L4hVR0uyFXYIBGE6Y59k5NG6T5YUm/qZwswvL9Rt+I6s l5T+MRfID4+/BoP3ThELmbXSGii6XyxV0OFEpMOs636A9qTnoKVeYYabPElEEN6Xe5vC Nr7syQmAgolMoTnmMhQ8WVviJfkasp2iutDTfbI456+7C0VrBrnmL2qF8rtGq1C+4l6r +AsBV2lmqlLiyxcsi+aCZQBk4dTfSLLUHVxMKem6SRP5Aj+IDhoeKNYeb/jME9X9ws1Z EuKdSJ8GMg/7uYh9WI1qJieZ0gCu6ILl/CnZtcNla+MjF7XttbLA3tMG9T201y/WtUxe amrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4STHvn45VW3tSwuQaAkxb8w0CsvHEqi7ZK830XrKDMg=; b=TEcXZcj5Unb3eBcZ8cKNd374FrdK6NewxkiAc12cEI90ePf0MxKkUzvFCbKzu3fuit /+zDrvOmsZ0onsxwXaIiPR0+d8VRrpPXjZ2UL6sWGP9j0wGhcE+BcB/AWSxFhtbarfb/ w7wHpjI2DIpuq3b8OaNth1sdwqBGLV/Rbx7GHf4NsOquj8QT/IjcmHNQmz8sVG71TRMx yghmPfgo7IhG1kohWk2YRaZMMycE4Ah7Hj21s5uC8z0GbDyGhhaijOvZOT7Axl26Em0w tcDmoSXyVPhmY7iUWaL6q5oN3sm05J5DeYG6EtH84haBhS5f6uVZdwnbKqet/DCQr2S4 eP2A== X-Gm-Message-State: ANhLgQ3w7ri1jxNgZhcTaAUVYP9raklMwHtcBTNwAyNRsxqgvbF6Ayel mO+lVo3zGbmc+4KBe+6k6+w1b5Xs13R5iQ== X-Google-Smtp-Source: ADFU+vsLL8Lfr67s9lGWh8hM+RTDQnvhaHrc4REbGtt/BH1YkTxqLTcxrHnotJEhSl2s33Ap3rKeIA== X-Received: by 2002:a63:82c6:: with SMTP id w189mr18317813pgd.357.1585675883786; Tue, 31 Mar 2020 10:31:23 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 198sm12999261pfa.87.2020.03.31.10.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Mar 2020 10:31:22 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , ophirmu@mellanox.com Date: Tue, 31 Mar 2020 10:31:06 -0700 Message-Id: <20200331173110.25746-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200331173110.25746-1-stephen@networkplumber.org> References: <20200331044156.31935-1-stephen@networkplumber.org> <20200331173110.25746-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 3/7] net/tap: do not use PMD logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The PMD logtype is legacy and drivers should use their own logtype. Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)") Cc: ophirmu@mellanox.com Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 05470a211588..2c9fb76b63de 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -778,7 +778,7 @@ tap_ioctl(struct pmd_internals *pmd, unsigned long request, case SIOCSIFMTU: break; default: - RTE_LOG(WARNING, PMD, "%s: ioctl() called with wrong arg\n", + TAP_LOG(WARNING, "%s: ioctl() called with wrong arg", pmd->name); return -EINVAL; } @@ -1301,7 +1301,9 @@ tap_gso_ctx_setup(struct rte_gso_ctx *gso_ctx, struct rte_eth_dev *dev) SOCKET_ID_ANY); if (!mp) { struct pmd_internals *pmd = dev->data->dev_private; - RTE_LOG(DEBUG, PMD, "%s: failed to create mbuf pool for device %s\n", + + TAP_LOG(ERR, + "%s: failed to create mbuf pool for device %s\n", pmd->name, dev->device->name); return -1; } -- 2.20.1