DPDK patches and discussions
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Finn Christensen <fc@napatech.com>,
	dev@dpdk.org, Bent Kuhre <bk@napatech.com>,
	Michael Lilja <ml@napatech.com>,
	techboard@dpdk.org
Subject: Re: [dpdk-dev] Napatech pmd
Date: Tue, 31 Mar 2020 15:56:55 -0400	[thread overview]
Message-ID: <20200331195655.GC3858830@hmswarspite.think-freely.org> (raw)
In-Reply-To: <11835288.hYdu0Ggh8K@xps>

On Tue, Mar 31, 2020 at 02:29:08PM +0200, Thomas Monjalon wrote:
> 31/03/2020 14:17, Neil Horman:
> > On Tue, Mar 31, 2020 at 01:25:25PM +0200, Thomas Monjalon wrote:
> > > Hi,
> > > 
> > > Raising this topic again.
> > > 
> > > As said in the past, it is better to have this PMD inside DPDK.
> > > We discussed some concerns, but I think the consensus was to integrate
> > > Napatech PMD anyway.
> > > 
> > > I am sad that you did not feel welcome enough to follow up with patches
> > > during all these years.
> > > Please would you like to restart the upstreaming process?
> > > 
> > Whats changed here?
> 
> Nothing changed, except years.
> 
> > I still don't see what the advantage is to accepting this code in the DPDK tree.
> > No one will be able to use it without accepting Napatechs license for their
> > underlying library.  As such, the code can't really be maintained at all by
> > anyone other than Napatech in the community, and so may as well just be
> > maintained as an out of tree driver.
> 
> You are the only one having this concern.
I don't think its wise to assume that silence implies acceptance.

> Nobody from the Technical Board looks to be against the acceptance.
> 
> The advantage is simple: Napatech customers will be able to run any DPDK version.
Why is that not possible by having napatech maintain an out-of-tree PMD?  Theres
no reason that can't be done.

Neil

> 
> 
> > > 08/01/2018 14:08, Finn Christensen:
> > > > Hi Thomas,
> > > > 
> > > > Thanks for bringing this discussion up again.
> > > > 
> > > > The Napatech PMD is build on top of our proprietary driver. The reason is basically that we utilize many years of driver development and thus reuses the FPGA controlling code in the DPDK PMD. The Napatech driver suite is still closed source.
> > > > The current NTNIC PMD dynamically links a Napatech proprietary NTAPI library to control the FPGA on our NICs.
> > > > 
> > > > We did think of the PMD as being our responsibility to keep updated towards the Napatech NIC communication, and that we would be engaged and asked to modify accordingly if changes in DPDK required that (maintainer). Furthermore, the PMD compiles with no issues, when NTNIC is enabled.
> > > > We have plans to write a stand-alone PMD, but this is not a small task to do, therefore we haven't got to that yet.
> > > > 
> > > > If the DPDK community would accept the dynamic linking to a proprietary library, from inside our PMD, then it would be great.
> > > > 
> > > > Let me know what you think. Or maybe you have ideas to what else we could do to make it upstream.
> > > > 
> > > > Thanks,
> > > > Finn
> > > > 
> > > > 
> > > > >-----Original Message-----
> > > > >From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > > >Sent: 5. januar 2018 16:34
> > > > >To: Finn Christensen <fc@napatech.com>
> > > > >Subject: Re: [dpdk-dev] standardize device identification
> > > > >
> > > > >It leads to a totally different question:
> > > > >Can we discuss again how to integrate your driver in DPDK upstream?
> > > > >Please explain again your situation in a new thread.
> > > > 
> > > 
> > > 
> > > 
> > > 
> > > 
> > > 
> > 
> 
> 
> 
> 
> 
> 

  parent reply	other threads:[~2020-03-31 19:57 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08 13:08 Finn Christensen
2018-01-08 15:15 ` Thomas Monjalon
2018-01-08 15:31   ` Stephen Hemminger
2018-01-09 10:43   ` Finn Christensen
2018-01-09 18:50   ` Neil Horman
2018-01-09 19:57     ` Michael Lilja
2018-01-09 20:20       ` Neil Horman
2018-01-09 20:36         ` Thomas Monjalon
2018-01-09 21:21           ` [dpdk-dev] [dpdk-techboard] " Stephen Hemminger
2018-01-10  0:24             ` Neil Horman
2018-01-10 10:21               ` Bruce Richardson
2018-01-10 12:28                 ` Neil Horman
2018-01-10  0:19           ` [dpdk-dev] " Neil Horman
2018-01-10  0:25             ` Thomas Monjalon
2020-03-31 11:25 ` Thomas Monjalon
2020-03-31 12:17   ` Neil Horman
2020-03-31 12:29     ` Thomas Monjalon
2020-03-31 12:39       ` Michael Lilja
2020-03-31 12:45         ` Thomas Monjalon
2020-03-31 13:08           ` Michael Lilja
2020-03-31 14:58         ` Stephen Hemminger
2020-03-31 19:51           ` Neil Horman
2020-03-31 19:59             ` Thomas Monjalon
2020-04-01 12:40               ` Neil Horman
2020-03-31 19:56       ` Neil Horman [this message]
2020-03-31 20:07         ` Thomas Monjalon
2020-04-01 12:49           ` Neil Horman
2020-04-17  2:54           ` Neil Horman
2020-04-17  4:38             ` Michael Lilja
2020-04-19 21:16               ` Neil Horman
2020-04-20  5:05                 ` Michael Lilja
2020-12-11  8:36                   ` Thomas Monjalon
2020-12-11  8:41                     ` Michael Lilja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200331195655.GC3858830@hmswarspite.think-freely.org \
    --to=nhorman@tuxdriver.com \
    --cc=bk@napatech.com \
    --cc=dev@dpdk.org \
    --cc=fc@napatech.com \
    --cc=ml@napatech.com \
    --cc=techboard@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).