From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30DC5A0577; Sun, 5 Apr 2020 23:54:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 390732B83; Sun, 5 Apr 2020 23:54:40 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id EABA5276C for ; Sun, 5 Apr 2020 23:54:38 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id ay1so5132042plb.0 for ; Sun, 05 Apr 2020 14:54:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IEKg/9Gc94aAdF2nesvMtuN4NDBMauk3pXJtahCcTTY=; b=lAxIqZeQ5EN3WBTx+NAGpf8XovxvhQcbMNDT0yEMQG8ZbnXnB9FiPa6F/atkP7AqXc oRUzARfT/96mBO5+/0E76cACOUkT917obWXnYs6loD/6fxCMAWoZLD0NHukRlW01ctwu RuW3znnQxhw3hZjb9q8I2pd9j0igD8eWOCl4ScAO8JNBaimfWZoVLO4uhvjBDyp3NRZP Mgwp4e6gh32iMP6Vnj4eYTZ2ZyxMBXuzLEoSpz4MrSpV7uY5yXWjG05bNvJ3VdUiP3/p ffmq/CNtYpxhu/E0nx6lLNa0I6CNc7bzFdc9mZWH5K3KhqhkmMp7FHHMohF+YrW+Gt8V 0W2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IEKg/9Gc94aAdF2nesvMtuN4NDBMauk3pXJtahCcTTY=; b=nbOl40co64meDhvczGCIuEYECazD9s/FjVvW+QVZf0E1eqdM1Pb0Upkx1z2F+3sR4X dnFUsY2y2fiHmZ78mlpHKLUnM756RAdAFiJlSj1GDOQ2nMlOvig9fM6u8zeL2cUrmmgQ mviG1kcRo4wxvu8BTqqBITQBsFZDKpTwCj01qBlGeSINhs/WdQ9aiOwTFyds0Zbh7ohE MU++OEiZJeF2d/ZyjJ7tABD2e3nPOjLObsVtQcOP9kOx0Aw5j83jujx4jA+9cpg/deHj ACxPmqJeZs7sO39VWSds56lh5Wf92THhS9EVCA6eutA+WGWgAEhedIZuGDwQ0tTCL5gy F0+Q== X-Gm-Message-State: AGi0PuaOVTytJVypWQUx+jtwaWvJcrj3dGpBlUqzd2wSRoptTCA4S1DZ ykCrRJ8cXd9QKRTqXkuj/i/e1w== X-Google-Smtp-Source: APiQypLM275+OFIXi5KHPIWvbbXOpcXtfexDQKK4IiiZDreV6c3chnMWha6s347tD+7lTqyf2lYLWw== X-Received: by 2002:a17:902:ac85:: with SMTP id h5mr16861860plr.76.1586123677774; Sun, 05 Apr 2020 14:54:37 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id i14sm9415981pgh.47.2020.04.05.14.54.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Apr 2020 14:54:37 -0700 (PDT) Date: Sun, 5 Apr 2020 14:54:29 -0700 From: Stephen Hemminger To: "Dey, Souvik" Cc: rmody@marvell.com, shshaikh@marvell.com, jerinj@marvell.com, ferruh.yigit@intel.com, thomas@monjalon.net, dev@dpdk.org, stable@dpdk.org Message-ID: <20200405145429.0fa51dea@hermes.lan> In-Reply-To: <20200228200451.2128-1-sodey@rbbn.com> References: <20200228200451.2128-1-sodey@rbbn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: add multicast MAC address filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 28 Feb 2020 15:04:51 -0500 "Dey, Souvik" wrote: > + /* Configure the previously stored Multicast address list */ > + if (IS_VF(sc)) { > + bnx2x_vfpf_set_mcast(sc, sc->mc_addrs, sc->mc_addrs_num); > + } Did you run checkpatch on this, the indentation does not match DPDK style. ### [PATCH] net/bnx2x: add multicast MAC address filtering WARNING:LEADING_SPACE: please, no spaces at the start of a line #31: FILE: drivers/net/bnx2x/bnx2x.h:1381: + uint16_t mc_addrs_num; /* Multicast mac addresses number */$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8) #44: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:243: + if (IS_VF(sc)) { + bnx2x_vfpf_set_mcast(sc, sc->mc_addrs, sc->mc_addrs_num); WARNING:BRACES: braces {} are not necessary for single statement blocks #44: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:243: + if (IS_VF(sc)) { + bnx2x_vfpf_set_mcast(sc, sc->mc_addrs, sc->mc_addrs_num); + } ERROR:CODE_INDENT: code indent should use tabs where possible #45: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:244: + bnx2x_vfpf_set_mcast(sc, sc->mc_addrs, sc->mc_addrs_num);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #45: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:244: + bnx2x_vfpf_set_mcast(sc, sc->mc_addrs, sc->mc_addrs_num);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #46: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:245: + }$ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #56: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:275: + * Number is set to 0 denoting DEL_CMD */ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8) #57: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:276: + if (IS_VF(sc)) { + bnx2x_vfpf_set_mcast(sc, NULL, 0); WARNING:BRACES: braces {} are not necessary for single statement blocks #57: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:276: + if (IS_VF(sc)) { + bnx2x_vfpf_set_mcast(sc, NULL, 0); + } ERROR:CODE_INDENT: code indent should use tabs where possible #58: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:277: + bnx2x_vfpf_set_mcast(sc, NULL, 0);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #58: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:277: + bnx2x_vfpf_set_mcast(sc, NULL, 0);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #59: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:278: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #72: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:366: + struct bnx2x_softc *sc = dev->data->dev_private;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #73: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:367: + int err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #74: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:368: + PMD_INIT_FUNC_TRACE(sc);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #76: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:370: + err = bnx2x_vfpf_set_mcast(sc, NULL, 0);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #77: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:371: + if (err)$ ERROR:CODE_INDENT: code indent should use tabs where possible #78: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:372: + return err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #78: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:372: + return err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #79: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:373: + sc->mc_addrs_num = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #82: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:376: + err = bnx2x_vfpf_set_mcast(sc, mc_addrs, mc_addrs_num );$ ERROR:SPACING: space prohibited before that close parenthesis ')' #82: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:376: + err = bnx2x_vfpf_set_mcast(sc, mc_addrs, mc_addrs_num ); WARNING:LEADING_SPACE: please, no spaces at the start of a line #83: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:377: + if (err)$ ERROR:CODE_INDENT: code indent should use tabs where possible #84: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:378: + return err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #84: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:378: + return err;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #86: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:380: + sc->mc_addrs_num = mc_addrs_num;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #87: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:381: + memcpy(sc->mc_addrs, mc_addrs, mc_addrs_num * sizeof(*mc_addrs));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #89: FILE: drivers/net/bnx2x/bnx2x_ethdev.c:383: + return 0;$ WARNING:LONG_LINE: line over 80 characters #114: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:709: + struct rte_ether_addr *mc_addrs, uint32_t mc_addrs_num) WARNING:LEADING_SPACE: please, no spaces at the start of a line #116: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:711: + struct vf_set_q_filters_tlv *query;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #117: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:712: + struct vf_common_reply_tlv *reply = &sc->vf2pf_mbox->resp.common_reply;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #118: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:713: + int rc = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #119: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:714: + uint32_t i = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #120: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:715: + query = &sc->vf2pf_mbox->query[0].set_q_filters;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #121: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:716: + bnx2x_vf_prep(sc, &query->first_tlv, BNX2X_VF_TLV_SET_Q_FILTERS,$ ERROR:CODE_INDENT: code indent should use tabs where possible #122: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:717: + sizeof(*query));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #122: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:717: + sizeof(*query));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #124: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:719: + if (mc_addrs_num > VF_MAX_MULTICAST_PER_VF) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #125: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:720: + PMD_DRV_LOG(ERR, sc,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #125: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:720: + PMD_DRV_LOG(ERR, sc,$ ERROR:CODE_INDENT: code indent should use tabs where possible #129: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:724: + rc = -EINVAL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #129: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:724: + rc = -EINVAL;$ ERROR:CODE_INDENT: code indent should use tabs where possible #130: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:725: + goto out;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #130: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:725: + goto out;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #131: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:726: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #133: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:728: + for (i = 0; i < mc_addrs_num; i++) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #134: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:729: + PMD_DRV_LOG(DEBUG, sc, "Adding mcast MAC:%x:%x:%x:%x:%x:%x",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #134: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:729: + PMD_DRV_LOG(DEBUG, sc, "Adding mcast MAC:%x:%x:%x:%x:%x:%x",$ ERROR:CODE_INDENT: code indent should use tabs where possible #135: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:730: + mc_addrs[i].addr_bytes[0],$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #135: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:730: + mc_addrs[i].addr_bytes[0],$ ERROR:CODE_INDENT: code indent should use tabs where possible #136: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:731: + mc_addrs[i].addr_bytes[1],$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #136: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:731: + mc_addrs[i].addr_bytes[1],$ ERROR:CODE_INDENT: code indent should use tabs where possible #137: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:732: + mc_addrs[i].addr_bytes[2],$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #137: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:732: + mc_addrs[i].addr_bytes[2],$ ERROR:CODE_INDENT: code indent should use tabs where possible #138: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:733: + mc_addrs[i].addr_bytes[3],$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #138: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:733: + mc_addrs[i].addr_bytes[3],$ ERROR:CODE_INDENT: code indent should use tabs where possible #139: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:734: + mc_addrs[i].addr_bytes[4],$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #139: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:734: + mc_addrs[i].addr_bytes[4],$ ERROR:CODE_INDENT: code indent should use tabs where possible #140: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:735: + mc_addrs[i].addr_bytes[5]);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #140: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:735: + mc_addrs[i].addr_bytes[5]);$ ERROR:CODE_INDENT: code indent should use tabs where possible #141: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:736: + memcpy(query->multicast[i], mc_addrs[i].addr_bytes, ETH_ALEN);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #141: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:736: + memcpy(query->multicast[i], mc_addrs[i].addr_bytes, ETH_ALEN);$ ERROR:CODE_INDENT: code indent should use tabs where possible #142: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:737: + i++;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #142: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:737: + i++;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #143: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:738: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #145: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:740: + query->vf_qid = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #146: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:741: + query->flags = BNX2X_VF_MULTICAST_CHANGED;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #147: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:742: + query->multicast_cnt = i;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #150: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:745: + bnx2x_add_tlv(sc, query, query->first_tlv.tl.length,$ ERROR:CODE_INDENT: code indent should use tabs where possible #151: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:746: + BNX2X_VF_TLV_LIST_END,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #151: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:746: + BNX2X_VF_TLV_LIST_END,$ ERROR:CODE_INDENT: code indent should use tabs where possible #152: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:747: + sizeof(struct channel_list_end_tlv));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #152: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:747: + sizeof(struct channel_list_end_tlv));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #154: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:749: + rc = bnx2x_do_req4pf(sc, sc->vf2pf_mbox_mapping.paddr);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #155: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:750: + if (rc)$ ERROR:CODE_INDENT: code indent should use tabs where possible #156: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:751: + goto out;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #156: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:751: + goto out;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #158: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:753: + if (reply->status != BNX2X_VF_STATUS_SUCCESS) {$ ERROR:CODE_INDENT: code indent should use tabs where possible #159: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:754: + PMD_DRV_LOG(ERR, sc, "Set Rx mode/multicast failed: %d",$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #159: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:754: + PMD_DRV_LOG(ERR, sc, "Set Rx mode/multicast failed: %d",$ ERROR:CODE_INDENT: code indent should use tabs where possible #160: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:755: + reply->status);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #160: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:755: + reply->status);$ ERROR:CODE_INDENT: code indent should use tabs where possible #161: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:756: + rc = -EINVAL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #161: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:756: + rc = -EINVAL;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #162: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:757: + }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #165: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:760: + bnx2x_vf_finalize(sc, &query->first_tlv);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #167: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:762: + return rc;$ CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #169: FILE: drivers/net/bnx2x/bnx2x_vfpf.c:764: + +} total: 24 errors, 63 warnings, 1 checks, 139 lines checked 0/1 valid patch