DPDK patches and discussions
 help / color / mirror / Atom feed
From: eugeny.parshutin@linux.intel.com
To: thomas@monjalon.net, ferruh.yigit@intel.com, john.mcnamara@intel.com
Cc: dev@dpdk.org, eugeny.parshutin@linux.intel.com, roman.p.khatko@intel.com
Subject: [dpdk-dev] [PATCH v5] ethdev: fix for compiler warning when vtune profiling is on
Date: Mon,  6 Apr 2020 21:27:05 +0300	[thread overview]
Message-ID: <20200406182705.11190-1-eugeny.parshutin@linux.intel.com> (raw)

From: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>

Add the previous prototype for the 'profile_hook_rx_burst_cb' function
to fix the compiler warning when the DPDK is built with
'RTE_ETHDEV_PROFILE_WITH_VTUNE' config option enabled:
/home/dpdk/lib/librte_ethdev/ethdev_profile.c:17:1: warning:
no previous prototype for profile_hook_rx_burst_cb [-Wmissing-prototypes]

Fixes: 2c1bbab7f09d ("ethdev: change vtune profiling approach")
Cc: stable@dpdk.org

Signed-off-by: Eugeny Parshutin <eugeny.parshutin@linux.intel.com>
---
v2: Fix the commit message

v3: Fix the check-git-log.sh warnings:
- make headline shorter
- add 'Fixes' tag

v4: Adapt 'Fixes' section to commit message guidelines

v5: Solve review comments:
- add the 'Cc: stable@dpdk.org' tag
- move the function parameter list one line up
- remove '__rte_unused' tag from params type
---
 lib/librte_ethdev/ethdev_profile.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/lib/librte_ethdev/ethdev_profile.h b/lib/librte_ethdev/ethdev_profile.h
index 65031e6f3..e5ee4df82 100644
--- a/lib/librte_ethdev/ethdev_profile.h
+++ b/lib/librte_ethdev/ethdev_profile.h
@@ -24,4 +24,13 @@
 int
 __rte_eth_dev_profile_init(uint16_t port_id, struct rte_eth_dev *dev);
 
+#ifdef RTE_ETHDEV_PROFILE_WITH_VTUNE
+
+uint16_t
+profile_hook_rx_burst_cb(uint16_t port_id, uint16_t queue_id,
+	struct rte_mbuf *pkts[], uint16_t nb_pkts,
+	uint16_t max_pkts, void *user_param);
+
+#endif /* RTE_ETHDEV_PROFILE_WITH_VTUNE */
+
 #endif
-- 
2.17.1


             reply	other threads:[~2020-04-06 18:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-06 18:27 eugeny.parshutin [this message]
2020-04-07 10:26 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200406182705.11190-1-eugeny.parshutin@linux.intel.com \
    --to=eugeny.parshutin@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=roman.p.khatko@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).