From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90686A0597; Thu, 9 Apr 2020 11:24:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 71F241C1EB; Thu, 9 Apr 2020 11:24:00 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id D430F1C1C6 for ; Thu, 9 Apr 2020 11:23:58 +0200 (CEST) IronPort-SDR: jaQZ4BDVDwOeyRprsbxEldCu1yYDfYtps3IdOAjAw/IE7+MDzxWMAHv05EerEcryTAxzpeD3gI CvasLkQqU8qQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 02:23:57 -0700 IronPort-SDR: QsiiouCF9MJKPeivL2ABe7jAWax6J8jbjBeNISKHhQhwBNUyYMMQyvfaLFRevOxINMVI/P5TNt X1PsDOm7WwgQ== X-IronPort-AV: E=Sophos;i="5.72,362,1580803200"; d="scan'208";a="240568390" Received: from bricha3-mobl.ger.corp.intel.com ([10.214.222.217]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Apr 2020 02:23:54 -0700 Date: Thu, 9 Apr 2020 10:23:50 +0100 From: Bruce Richardson To: David Marchand Cc: Juraj =?utf-8?Q?Linke=C5=A1?= , Ciara Power , Aaron Conole , Michael Santana , dev Message-ID: <20200409092350.GD605@bricha3-MOBL.ger.corp.intel.com> References: <1585917949-13468-1-git-send-email-juraj.linkes@pantheon.tech> <1586350164-26429-1-git-send-email-juraj.linkes@pantheon.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 09, 2020 at 10:00:51AM +0200, David Marchand wrote: > Hello, > > On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš wrote: > > > > libjansson4 is not enough to build telemetry. Replace it with > > libjansson-dev. > > Thanks for the patch Juraj. > Just a little comment, for the v2, there was no significant change and > you could have kept Aaron and Ruifeng review tags. > > > I just want others' opinion, since there is a work on removing the > dependency on libjansson for telemetry. > That would be an end-goal but we are not fully there yet. Even with the rework some parts of the library for legacy compatibility still depend on jansson, though the majority of the code will compile without it. Therefore this dependency should be kept in the CI beyond this release, as we weren't planning on doing the additional work to completely replace it - though we can re-evaluate that if people think that it's important to remove the dependency completely. /Bruce