From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3D9FA0597; Sat, 11 Apr 2020 00:23:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0EC9B1D159; Sat, 11 Apr 2020 00:23:01 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id B95541C2F1 for <dev@dpdk.org>; Sat, 11 Apr 2020 00:22:59 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id b8so1592345pfp.8 for <dev@dpdk.org>; Fri, 10 Apr 2020 15:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SS35S0vmJe+X5fOXA/rqMtxqxt6pegIJiUEiRQ8Q4KA=; b=CocAzVuW2QKsfRkIdC3UI1Cs6LecvClq/RSxMvXhT8kod0kkEFhjGBGoKoRW9u9e3S SD9RWuItxPP8Ioc516D1VT8HUEKgI6Mb6ZHF+473BQjEhvD0DHHBgUx9dP2uEz5iiVJj nHuyTi8ZMd3A9LVf9X4yvJbltbW2sBpH9K0t8nrsH5kehIs4TQehH64OlGhUSt3WOT0Z GyGievDfUxU/jtz2RUIU97cqb1vAiCMU1wTBHUMry+8+WI4HLBohIvPkG2dKBJNANxeA KwaH1w1Z+jTmEZusrNVIji+FVyfEC/KvAXKefXeOTSqlu1vmTqXE77z09/TjNKmSivyD JQNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SS35S0vmJe+X5fOXA/rqMtxqxt6pegIJiUEiRQ8Q4KA=; b=AwwAteEYqM9/Vf4kUPmOwKLK087c1v7TWMzzgEqLnbkF6fw+3ihHeCDdSEjPsv5A+n RRPWOKkQ5sqQ3guDG/DPBoDByOdBXJmsQrKEh+CeEqGbV7/mdEMzD6KOY9yypFsjvDZm 5xF5gzJ2j5P9j8wR9rXJZ0DvbNkRGkt9gy0iioP6HXiHNcLKmArrkrQC3mKL/w/vIflR IiEwQ174X8BpPEXzu7Gp+jjpgwWYOKid0qBiLwcewbwmOJdMWvLtVTJlcobNqH4qGA12 Y7PYBXvYqJshWgACJBzpgo9nhDJbA7nAHEznZ6bgR93Lf0gbr1GQCe3fTtpfz1645EGd 3EsQ== X-Gm-Message-State: AGi0PubBtTGr4D6bMtLxdkJuGQG5eIkwVp9Ka9A9tx2AwplLLXKAXisp ds4ssDmsW2ZeaLXgeNFm031BdQ== X-Google-Smtp-Source: APiQypJs99QFSObdphzSLTPxYPhTTq9Tm5fWxoRws7nLGyB8tv4fXUpAVKLBMvEPKRYrsNfj2DPgvw== X-Received: by 2002:aa7:9a89:: with SMTP id w9mr6937479pfi.149.1586557378831; Fri, 10 Apr 2020 15:22:58 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w142sm2662287pff.111.2020.04.10.15.22.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 15:22:58 -0700 (PDT) Date: Fri, 10 Apr 2020 15:22:55 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> Cc: Thomas Monjalon <thomas@monjalon.net>, Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org, Aaron Conole <aconole@redhat.com>, Ruifeng Wang <ruifeng.wang@arm.com>, David Marchand <david.marchand@redhat.com>, Gavin Hu <gavin.hu@arm.com> Message-ID: <20200410152255.4565de32@hermes.lan> In-Reply-To: <ba0c9835-a94a-d013-d353-5975a748e4b2@partner.samsung.com> References: <20200409180332.592074-1-thomas@monjalon.net> <1813726.1xdlsreqCQ@thomas> <20200410132547.GB42@bricha3-MOBL.ger.corp.intel.com> <CGME20200410144137eucas1p2a55af8d4f5020dd425ae5a57b7abd8fc@eucas1p2.samsung.com> <1933780.kXSN5OTJKJ@thomas> <ba0c9835-a94a-d013-d353-5975a748e4b2@partner.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3] test: remove meson dependency on /proc file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Fri, 10 Apr 2020 22:47:44 +0200 Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> wrote: > W dniu 10.04.2020 o=C2=A016:41, Thomas Monjalon pisze: > > 10/04/2020 15:25, Bruce Richardson: =20 > >> On Fri, Apr 10, 2020 at 02:27:30PM +0200, Thomas Monjalon wrote: =20 > >>> 10/04/2020 12:42, Bruce Richardson: =20 > >>>> On Fri, Apr 10, 2020 at 12:29:50PM +0200, Thomas Monjalon wrote: =20 > >>>>> --- a/app/test/meson.build > >>>>> +++ b/app/test/meson.build > >>>>> has_hugepage =3D true > >>>>> if is_linux =20 > >>>> Since you check for linux in the script, you can drop these two line= s, =20 > >>> The issue is for Windows. > >>> I am not sure how we will skip shell scripts > >>> when adding Windows support for this application. > >>> So there are two options now: > >>> a) remove Linux check before calling the script and ignore Windows s= upport for now > >>> b) keep Linux check without knowing whether it will be useful for Wi= ndows support > >>> > >>> We vote a? > >>> =20 > >> c) Write all such scripts in python, to allow them to run everywhere. = :-) > >> > >> Given that windows is the problem, having the is_linux check in the > >> meson.build file makes most sense - in which case I don't think we nee= d the > >> check for linux in the script. =20 > > Yes, let's make it simple for now. > > =20 >=20 > a) is ok as the current meson.build won't work in Windows environment at= =20 > all. > c) would be best, but I guess it's a little bit to much for this patch=20 > and the whole build system could be adjusted to windows in separate threa= d. >=20 > And I agree with Bruce, that the check for Linux in script is not needed. >=20 > > =20 Building in a container may not give access to /proc.