From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C86AA0577; Mon, 13 Apr 2020 17:19:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F0481BF3C; Mon, 13 Apr 2020 17:19:42 +0200 (CEST) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by dpdk.org (Postfix) with ESMTP id 236552B96 for ; Mon, 13 Apr 2020 17:19:41 +0200 (CEST) Received: by mail-pj1-f53.google.com with SMTP id ng8so3955245pjb.2 for ; Mon, 13 Apr 2020 08:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h8s4YSZYjr3LE/yhO8dt7Fg8gEOpiYjwuFRlvpVLfUQ=; b=AfX8NQ7UOwWiBgEa3fbFmuPLuI3vV6dT6jOuOsXBElcyF6bc0qgFk+53GjBOrgSnuz y/TmhaEI8EzPIsEWdwcdb0n13fQJgcANY+KUixusQr2pbyArIF9uGOu/FHEAdP/RAVen Z/sQPAFcJbxbGMdvd2GcZr8f1I80E8tuVz37z7iw6cmtXJFdpLK3d1Y3yO2zB9CtiGNQ V3zcF1ApbP8kMKJjFYnYjiUg9BIOVzHjECzSxYF0Y+80ORspwCQkY618i2cAy8XXCR/F hScXcm+mv11IbLa0zsxTPh40DFlGoNQL9AfQit753Fk65FbprbgqcEZU5MI7l3jHY5kM Rrpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h8s4YSZYjr3LE/yhO8dt7Fg8gEOpiYjwuFRlvpVLfUQ=; b=bLsMq6qJTRRCAw6dyI/DthHrpaPCDQFJdASRaLN/KwF9KLHXayDixykrEg7bRIUdOa K1nqvsGZ25lx4eFm1g/vyL3GnOnLrgS46AQBvO9uFwvi91GZen4xq+YMe/e2dZos7NNd 8YhQ95xomvUhR4/HuvkB8Wzm9FpFiEWK2Imoem5m0ei+nx7CC2BpDh1phtSxKyPMUBjo wWXtTNVMg8+ml+1M+rTSzF05+ThZpa8VMgLsvhSkpu1V7PjX3XZo17+Kp0bwPkPNsIEg MJhBCTaGR8Z/dD4BIn0fl7FBsJHNdWqRD55NOLnLti3ceBaaaxvCA3ngy+eSoV8Mvu5h FmYw== X-Gm-Message-State: AGi0PuaW13oeNp9q5DmN+wh8VOpKOoAZhXME57mIvnIbDelpAYhTAGUG hJZvoTdX34ijQGlVER3wgoiYmg== X-Google-Smtp-Source: APiQypJdWjuW/d5hOp8ys/PU2uPv54xV7Rmd8LM4riZ4Qkl0mQOZ7r+fKk2EVRB3XKjDR781YWonMQ== X-Received: by 2002:a17:902:b617:: with SMTP id b23mr18822773pls.194.1586791180119; Mon, 13 Apr 2020 08:19:40 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id 18sm9011976pfv.118.2020.04.13.08.19.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2020 08:19:39 -0700 (PDT) Date: Mon, 13 Apr 2020 08:19:31 -0700 From: Stephen Hemminger To: alvinx.zhang@intel.com Cc: dev@dpdk.org, xiaolong.ye@intel.com Message-ID: <20200413081931.653777a2@hermes.lan> In-Reply-To: <20200413063037.13728-2-alvinx.zhang@intel.com> References: <20200413063037.13728-1-alvinx.zhang@intel.com> <20200413063037.13728-2-alvinx.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 01/11] net/igc: add igc PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 13 Apr 2020 14:30:27 +0800 alvinx.zhang@intel.com wrote: > + if (dev->data->mac_addrs == NULL) { > + PMD_INIT_LOG(ERR, "Failed to allocate %d bytes needed to " > + "store MAC addresses", RTE_ETHER_ADDR_LEN); Stylistic note. Please don't break messages across multiple lines, it makes it harder to read, and also harder for users to search for error messages. If you are concerned about checkpatch, checkpatch allows long lines for messages. PMD_INIT_LOG(ERR, "Failed allocation for MAC address");