DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev]  [PATCH] net/iavf: fix return value of stats get function
@ 2020-04-14  1:56 cheng.peng5
  2020-04-22  7:27 ` Ye Xiaolong
  0 siblings, 1 reply; 2+ messages in thread
From: cheng.peng5 @ 2020-04-14  1:56 UTC (permalink / raw)
  To: jingjing.wu, wenzhuo.lu; +Cc: dev, cheng.peng5

The iavf_dev_stats_get function should return ret instead of -eio.

Signed-off-by: Peng Cheng <cheng.peng5@zte.com.cn>
---
 drivers/net/iavf/iavf_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 34913f9..93ab121 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1074,7 +1074,7 @@ iavf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 	} else {
 		PMD_DRV_LOG(ERR, "Get statistics failed");
 	}
-	return -EIO;
+	return ret;
 }

 static int
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/iavf: fix return value of stats get function
  2020-04-14  1:56 [dpdk-dev] [PATCH] net/iavf: fix return value of stats get function cheng.peng5
@ 2020-04-22  7:27 ` Ye Xiaolong
  0 siblings, 0 replies; 2+ messages in thread
From: Ye Xiaolong @ 2020-04-22  7:27 UTC (permalink / raw)
  To: cheng.peng5; +Cc: jingjing.wu, wenzhuo.lu, dev

Hi, 

Thanks for the fix.

On 04/14, cheng.peng5@zte.com.cn wrote:
>The iavf_dev_stats_get function should return ret instead of -eio.
>

Fixes: f4a41a6953af ("net/avf: support stats")
Cc: stable@dpdk.org

>Signed-off-by: Peng Cheng <cheng.peng5@zte.com.cn>
>---
> drivers/net/iavf/iavf_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
>index 34913f9..93ab121 100644
>--- a/drivers/net/iavf/iavf_ethdev.c
>+++ b/drivers/net/iavf/iavf_ethdev.c
>@@ -1074,7 +1074,7 @@ iavf_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
> 	} else {
> 		PMD_DRV_LOG(ERR, "Get statistics failed");
> 	}
>-	return -EIO;
>+	return ret;
> }
>
> static int
>-- 
>1.8.3.1

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel with fixes tag and cc table, Thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-22  7:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14  1:56 [dpdk-dev] [PATCH] net/iavf: fix return value of stats get function cheng.peng5
2020-04-22  7:27 ` Ye Xiaolong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).