From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: declan.doherty@intel.com
Cc: dev@dpdk.org, akhil.goyal@nxp.com,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Adam Dybkowski <adamx.dybkowski@intel.com>
Subject: [dpdk-dev] [PATCH v4 2/2] test/crypto: do not check for internal PMD information
Date: Thu, 16 Apr 2020 10:08:19 +0100 [thread overview]
Message-ID: <20200416090819.1921843-3-pablo.de.lara.guarch@intel.com> (raw)
In-Reply-To: <20200416090819.1921843-1-pablo.de.lara.guarch@intel.com>
Now that capabilities are checked to see if an algorithm
is supported by a device, there is no need to check
for a specific version of a library used in a PMD.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
app/test/test_cryptodev_hash_test_vectors.h | 25 -------------------------
1 file changed, 25 deletions(-)
diff --git a/app/test/test_cryptodev_hash_test_vectors.h b/app/test/test_cryptodev_hash_test_vectors.h
index cff2831..2ed077f 100644
--- a/app/test/test_cryptodev_hash_test_vectors.h
+++ b/app/test/test_cryptodev_hash_test_vectors.h
@@ -9,11 +9,6 @@
#include <intel-ipsec-mb.h>
#endif
-#if !defined(IMB_VERSION_NUM)
-#define IMB_VERSION(a, b, c) (((a) << 16) + ((b) << 8) + (c))
-#define IMB_VERSION_NUM IMB_VERSION(0, 49, 0)
-#endif
-
static const uint8_t plaintext_hash[] = {
"What a lousy earth! He wondered how many people "
"were destitute that same night even in his own "
@@ -462,9 +457,7 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_CCP |
BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 52, 0)
BLOCKCIPHER_TEST_TARGET_PMD_MB |
-#endif
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2
},
@@ -475,9 +468,7 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_CCP |
BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 52, 0)
BLOCKCIPHER_TEST_TARGET_PMD_MB |
-#endif
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2
},
@@ -542,9 +533,7 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_CCP |
BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 52, 0)
BLOCKCIPHER_TEST_TARGET_PMD_MB |
-#endif
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2
},
@@ -555,9 +544,7 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_CCP |
BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 52, 0)
BLOCKCIPHER_TEST_TARGET_PMD_MB |
-#endif
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2
},
@@ -598,9 +585,7 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_CCP |
BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 52, 0)
BLOCKCIPHER_TEST_TARGET_PMD_MB |
-#endif
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2
},
@@ -611,9 +596,7 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_CCP |
BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 52, 0)
BLOCKCIPHER_TEST_TARGET_PMD_MB |
-#endif
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2
},
@@ -656,9 +639,7 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_CCP |
BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 52, 0)
BLOCKCIPHER_TEST_TARGET_PMD_MB |
-#endif
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2
},
@@ -669,9 +650,7 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_CCP |
BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 52, 0)
BLOCKCIPHER_TEST_TARGET_PMD_MB |
-#endif
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2
},
@@ -714,9 +693,7 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_CCP |
BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 52, 0)
BLOCKCIPHER_TEST_TARGET_PMD_MB |
-#endif
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX
},
{
@@ -726,9 +703,7 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_CCP |
BLOCKCIPHER_TEST_TARGET_PMD_MVSAM |
-#if IMB_VERSION_NUM >= IMB_VERSION(0, 52, 0)
BLOCKCIPHER_TEST_TARGET_PMD_MB |
-#endif
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX |
BLOCKCIPHER_TEST_TARGET_PMD_OCTEONTX2
},
--
2.7.5
next prev parent reply other threads:[~2020-04-16 13:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 10:22 [dpdk-dev] [PATCH 1/2] test/crypto: add capability check Pablo de Lara
2020-04-14 10:22 ` [dpdk-dev] [PATCH 2/2] test/crypto: do not check for IMB_VERSION_NUM Pablo de Lara
2020-04-14 10:34 ` Thomas Monjalon
2020-04-14 17:22 ` De Lara Guarch, Pablo
2020-04-14 17:48 ` Thomas Monjalon
2020-04-22 9:16 ` Thomas Monjalon
2020-04-22 9:43 ` Akhil Goyal
2020-04-22 10:56 ` Thomas Monjalon
2020-04-15 10:28 ` Dybkowski, AdamX
2020-04-14 10:35 ` [dpdk-dev] [PATCH v2 1/2] test/crypto: add capability check Pablo de Lara
2020-04-14 10:35 ` [dpdk-dev] [PATCH v2 2/2] test/crypto: do not check for IMB_VERSION_NUM Pablo de Lara
2020-04-15 10:30 ` Dybkowski, AdamX
2020-04-14 17:40 ` [dpdk-dev] [PATCH v3 0/2] Crypto test refactoring (first phase) Pablo de Lara
2020-04-14 17:40 ` [dpdk-dev] [PATCH v3 1/2] test/crypto: add capability check Pablo de Lara
2020-04-15 10:31 ` Dybkowski, AdamX
2020-04-16 11:15 ` De Lara Guarch, Pablo
2020-04-14 17:40 ` [dpdk-dev] [PATCH v3 2/2] test/crypto: do not check for internal PMD information Pablo de Lara
2020-04-15 10:30 ` Dybkowski, AdamX
2020-04-16 9:08 ` [dpdk-dev] [PATCH v4 0/2] Crypto test refactoring (first phase) Pablo de Lara
2020-04-16 9:08 ` [dpdk-dev] [PATCH v4 1/2] test/crypto: add capability check Pablo de Lara
2020-04-16 15:35 ` Ruifeng Wang
2020-04-16 16:26 ` Trahe, Fiona
2020-04-16 16:44 ` De Lara Guarch, Pablo
2020-04-16 9:08 ` Pablo de Lara [this message]
2020-04-16 15:35 ` [dpdk-dev] [PATCH v4 2/2] test/crypto: do not check for internal PMD information Ruifeng Wang
2020-04-16 17:24 ` [dpdk-dev] [PATCH v5 0/2] Crypto test refactoring (first phase) Pablo de Lara
2020-04-16 17:24 ` [dpdk-dev] [PATCH v5 1/2] test/crypto: add capability check Pablo de Lara
2020-04-16 17:53 ` Trahe, Fiona
2020-04-16 17:24 ` [dpdk-dev] [PATCH v5 2/2] test/crypto: do not check for internal PMD information Pablo de Lara
2020-04-16 17:53 ` Trahe, Fiona
2020-04-19 21:15 ` [dpdk-dev] [PATCH v5 0/2] Crypto test refactoring (first phase) Akhil Goyal
2020-04-15 10:29 ` [dpdk-dev] [PATCH v2 1/2] test/crypto: add capability check Dybkowski, AdamX
2020-04-15 9:16 ` [dpdk-dev] [PATCH " Dybkowski, AdamX
2020-04-15 9:23 ` Dybkowski, AdamX
2020-04-15 10:29 ` Dybkowski, AdamX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416090819.1921843-3-pablo.de.lara.guarch@intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=adamx.dybkowski@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).