From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8517A0561; Tue, 21 Apr 2020 05:19:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADE8E1D5C9; Tue, 21 Apr 2020 05:19:22 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id CC8C61C2B9 for ; Tue, 21 Apr 2020 05:19:21 +0200 (CEST) IronPort-SDR: Xk5slVkG/eIoow+gOVA/kjNBRiQFEvrJ80dQ9u64BNoOUgVgYbE/gWn13N2P37xugrW86teVNv nzzx0HP3qoKw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2020 20:19:20 -0700 IronPort-SDR: ZwuEY/TS9w/gTXOMWVnzpO6EzY+KugvF1q8hTOq+++NhBBr3YGW5wwXEmuOTuZJG/yRWFP0We4 NOjB9u0Pn1tA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,408,1580803200"; d="scan'208";a="258561511" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga006.jf.intel.com with ESMTP; 20 Apr 2020 20:19:19 -0700 Date: Tue, 21 Apr 2020 11:14:59 +0800 From: Ye Xiaolong To: Leyi Rong Cc: jingjing.wu@intel.com, qi.z.zhang@intel.com, beilei.xing@intel.com, dev@dpdk.org Message-ID: <20200421031459.GG33101@intel.com> References: <20200316074603.10998-1-leyi.rong@intel.com> <20200420061625.21424-1-leyi.rong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200420061625.21424-1-leyi.rong@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v6 00/11] framework for advanced iAVF PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/20, Leyi Rong wrote: >This patchset enable framework for advanced iAVF, includes >flexible descriptor support, FDIR mark id and RSS hash support. > >--- >v6: >- Remove some redundant code which may cause ICC build error. > >v5: >- Set rxdid = 0 in iavf_configure_queues() when it's supported and > RTE_LIBRTE_IAVF_16BYTE_RX_DESC is y. So the error can be captured > explicitly as kernel PF does not support it yet. >- Fix some build errors when RTE_LIBRTE_IAVF_16BYTE_RX_DESC is y. > >v4: >- Avoid initial declaration in 'for' loop to backward-compatible > with older gcc versions. > >v3: >- Remove patch to query DDP package info as it's specific to DCF. >- Specify fdir_ref_cnt as per VF value for enable/disable FDIR ID parse. >- Move fdir_enabled flag to per Queue value for cache benefit when > access in vector routines. >- Store extracted flow_id value to mbuf without judgement to avoid > branch speculation fail, which is benefit to performance. > >v2: >- Revert macro RTE_LIBRTE_IAVF_16BYTE_RX_DESC deletion as > it's defined in AVF spec. >- Typo RTE_LIBRTE_ICE_16BYTE_RX_DESC fix in iavf_rxtx.c. >- Move flex desc definitions into iavf_rxtx.h. >- Up to date to match with the latest version of virtchnl.h. >- Extract a new internal func iavf_update_rx_tail to call. >- Remove > iavf_dev_rxq_count_flex_rxd()/iavf_dev_rx_desc_status_flex_rxd(), > as the accompanying legacy ones can deal with the flex desc cases. >- Move rxq->rxdid assignment from iavf_configure_queues() > to iavf_dev_rx_queue_setup(). >- Unfold _mm_extract_epi32(fdir_id0_3, i) to fix build error > when using GCC compile option -O0. > >Leyi Rong (11): > net/iavf: flexible Rx descriptor definitions > net/iavf: return error if opcode is mismatched > net/iavf: flexible Rx descriptor support in normal path > net/iavf: flexible Rx descriptor support in AVX path > net/iavf: flexible Rx descriptor support in SSE path > net/iavf: add flow director enabled switch value > net/iavf: support flow mark in normal data path > net/iavf: support flow mark in AVX path > net/iavf: support flow mark in SSE path > net/iavf: add RSS hash parsing in AVX path > net/iavf: add RSS hash parsing in SSE path > > drivers/net/iavf/iavf.h | 6 + > drivers/net/iavf/iavf_ethdev.c | 8 + > drivers/net/iavf/iavf_rxtx.c | 546 ++++++++++++++++++-- > drivers/net/iavf/iavf_rxtx.h | 250 ++++++++++ > drivers/net/iavf/iavf_rxtx_vec_avx2.c | 691 ++++++++++++++++++++++++++ > drivers/net/iavf/iavf_rxtx_vec_sse.c | 520 +++++++++++++++++++ > drivers/net/iavf/iavf_vchnl.c | 59 ++- > 7 files changed, 2035 insertions(+), 45 deletions(-) > >-- >2.17.1 > Applied to dpdk-next-net-intel, Thanks.