DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Haiyue Wang <haiyue.wang@intel.com>
Cc: dev@dpdk.org, qi.z.zhang@intel.com, qiming.yang@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] net/ice: check the DSN package file firstly
Date: Tue, 21 Apr 2020 11:17:43 +0800	[thread overview]
Message-ID: <20200421031743.GH33101@intel.com> (raw)
In-Reply-To: <20200416031122.59640-1-haiyue.wang@intel.com>

On 04/16, Haiyue Wang wrote:
>Align the package file search sequence with PF only for DCF mode. Get
>the DSN through the virtual channel firstly to check the package file
>accessible.
>
>Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
>---
> drivers/net/ice/ice_dcf_parent.c | 30 ++++++++++++++++++++++++++----
> 1 file changed, 26 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c
>index e05b6b3e5..d4b4ededb 100644
>--- a/drivers/net/ice/ice_dcf_parent.c
>+++ b/drivers/net/ice/ice_dcf_parent.c
>@@ -226,12 +226,34 @@ ice_dcf_request_pkg_name(struct ice_hw *hw, char *pkg_name)
> {
> 	struct ice_dcf_adapter *dcf_adapter =
> 			container_of(hw, struct ice_dcf_adapter, parent.hw);
>+	struct virtchnl_pkg_info pkg_info;
>+	struct dcf_virtchnl_cmd vc_cmd;
>+	uint64_t dsn;
> 
>-	/* TODO: check with DSN firstly by iAVF */
>-	PMD_INIT_LOG(DEBUG,
>-		     "DCF VSI_ID = %u",
>-		     dcf_adapter->real_hw.vsi_id);
>+	vc_cmd.v_op = VIRTCHNL_OP_DCF_GET_PKG_INFO;
>+	vc_cmd.req_msglen = 0;
>+	vc_cmd.req_msg = NULL;
>+	vc_cmd.rsp_buflen = sizeof(pkg_info);
>+	vc_cmd.rsp_msgbuf = (uint8_t *)&pkg_info;
> 
>+	if (ice_dcf_execute_virtchnl_cmd(&dcf_adapter->real_hw, &vc_cmd))
>+		goto pkg_file_direct;
>+
>+	rte_memcpy(&dsn, pkg_info.dsn, sizeof(dsn));
>+
>+	snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE,
>+		 ICE_PKG_FILE_SEARCH_PATH_UPDATES "ice-%016llX.pkg",
>+		 (unsigned long long)dsn);
>+	if (!access(pkg_name, 0))
>+		return 0;
>+
>+	snprintf(pkg_name, ICE_MAX_PKG_FILENAME_SIZE,
>+		 ICE_PKG_FILE_SEARCH_PATH_DEFAULT "ice-%016llX.pkg",
>+		 (unsigned long long)dsn);
>+	if (!access(pkg_name, 0))
>+		return 0;
>+
>+pkg_file_direct:
> 	snprintf(pkg_name,
> 		 ICE_MAX_PKG_FILENAME_SIZE, "%s", ICE_PKG_FILE_UPDATES);
> 	if (!access(pkg_name, 0))
>-- 
>2.26.1
>

Applied to dpdk-next-net-intel, Thanks.

      parent reply	other threads:[~2020-04-21  3:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-16  3:11 Haiyue Wang
2020-04-17  4:50 ` Ye Xiaolong
2020-04-17  5:08   ` Wang, Haiyue
2020-04-20  4:59 ` Zhang, Qi Z
2020-04-21  3:17 ` Ye Xiaolong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200421031743.GH33101@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).