From: Gavin Hu <gavin.hu@arm.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, xiaolong.ye@intel.com,
david.marchand@redhat.com, thomas@monjalon.net,
Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com,
Phil.Yang@arm.com, Joyce.Kong@arm.com, rasland@mellanox.com,
stable@dpdk.org
Subject: [dpdk-dev] [patch v1] net/i40e: fix the compile issue
Date: Tue, 21 Apr 2020 17:49:52 +0800 [thread overview]
Message-ID: <20200421094952.28656-1-gavin.hu@arm.com> (raw)
Using gcc version 4.8.5 20150623 (Red Hat 4.8.5-28), it reports the
following compiling error:
/download/dpdk/drivers/net/i40e/i40e_rxtx_vec_neon.c:175:65: error:
expected ';', ',' or ')' before 'rx_pkts' desc_to_ptype_v(uint64x2_t
descs[4], struct rte_mbuf **restrict rx_pkts, ^
/download/dpdk/drivers/net/i40e/i40e_rxtx_vec_neon.c:197:51: error:
expected ';', ',' or ')' before 'rxq' _recv_raw_pkts_vec(struct
i40e_rx_queue *restrict rxq, struct rte_mbuf ^
/download/dpdk/drivers/net/i40e/i40e_rxtx_vec_neon.c:435:35: error:
expected ';', ',' or ')' before 'rx_queue' i40e_recv_pkts_vec(void
*restrict rx_queue, struct rte_mbuf **restrict rx_pkts,
Fix this by using '__restrict' type qualifier, which compiles ok with
old and new versions of gcc.
Fixes: 8499b1748f26 ("net/i40e: restrict pointer aliasing for NEON")
Cc: stable@dpdk.org
Signed-off-by: Gavin Hu <gavin.hu@arm.com>
---
drivers/net/i40e/i40e_rxtx_vec_neon.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c
index 258b42e4d..1dfd0478b 100644
--- a/drivers/net/i40e/i40e_rxtx_vec_neon.c
+++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c
@@ -172,8 +172,8 @@ desc_to_olflags_v(struct i40e_rx_queue *rxq, uint64x2_t descs[4],
#define I40E_UINT16_BIT (CHAR_BIT * sizeof(uint16_t))
static inline void
-desc_to_ptype_v(uint64x2_t descs[4], struct rte_mbuf **restrict rx_pkts,
- uint32_t *restrict ptype_tbl)
+desc_to_ptype_v(uint64x2_t descs[4], struct rte_mbuf **__restrict rx_pkts,
+ uint32_t *__restrict ptype_tbl)
{
int i;
uint8_t ptype;
@@ -194,8 +194,8 @@ desc_to_ptype_v(uint64x2_t descs[4], struct rte_mbuf **restrict rx_pkts,
* numbers of DD bits
*/
static inline uint16_t
-_recv_raw_pkts_vec(struct i40e_rx_queue *restrict rxq, struct rte_mbuf
- **restrict rx_pkts, uint16_t nb_pkts, uint8_t *split_packet)
+_recv_raw_pkts_vec(struct i40e_rx_queue *__restrict rxq, struct rte_mbuf
+ **__restrict rx_pkts, uint16_t nb_pkts, uint8_t *split_packet)
{
volatile union i40e_rx_desc *rxdp;
struct i40e_rx_entry *sw_ring;
@@ -432,8 +432,8 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *restrict rxq, struct rte_mbuf
* numbers of DD bits
*/
uint16_t
-i40e_recv_pkts_vec(void *restrict rx_queue, struct rte_mbuf **restrict rx_pkts,
- uint16_t nb_pkts)
+i40e_recv_pkts_vec(void *__restrict rx_queue,
+ struct rte_mbuf **__restrict rx_pkts, uint16_t nb_pkts)
{
return _recv_raw_pkts_vec(rx_queue, rx_pkts, nb_pkts, NULL);
}
@@ -504,8 +504,8 @@ vtx(volatile struct i40e_tx_desc *txdp, struct rte_mbuf **pkt,
}
uint16_t
-i40e_xmit_fixed_burst_vec(void *restrict tx_queue,
- struct rte_mbuf **restrict tx_pkts, uint16_t nb_pkts)
+i40e_xmit_fixed_burst_vec(void *__restrict tx_queue,
+ struct rte_mbuf **__restrict tx_pkts, uint16_t nb_pkts)
{
struct i40e_tx_queue *txq = (struct i40e_tx_queue *)tx_queue;
volatile struct i40e_tx_desc *txdp;
--
2.17.1
next reply other threads:[~2020-04-21 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 9:49 Gavin Hu [this message]
2020-04-21 9:51 ` Ferruh Yigit
2020-04-21 11:06 ` Raslan Darawsheh
2020-04-21 11:56 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200421094952.28656-1-gavin.hu@arm.com \
--to=gavin.hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Joyce.Kong@arm.com \
--cc=Phil.Yang@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).