[dpdk-dev] [PATCH] app: fix usage help of options separated by dashes

[dpdk-dev] [PATCH] app: fix usage help of options separated by dashes

[Thomas Monjalon]

The EAL options and app-specific options are separated
with double dashes.

The help of testpmd, test-acl and pdump were missing
the dashes after EAL options.
Note: testpmd was completely missing the EAL options.

Fixes: af75078fece3 ("first public release")
Fixes: 26c057ab6c45 ("acl: new test-acl application")
Fixes: b2854d5317e8 ("app/pdump: support multi-core capture")
Cc: vipin.varghese@intel.com
Cc: stable@dpdk.org

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 app/pdump/main.c          | 2 +-
 app/test-acl/main.c       | 2 +-
 app/test-pmd/parameters.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/pdump/main.c b/app/pdump/main.c
index d05a023667..c38c53719e 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -151,7 +151,7 @@ static uint8_t multiple_core_capture;
 static void
 pdump_usage(const char *prgname)
 {
-	printf("usage: %s [EAL options]"
+	printf("usage: %s [EAL options] --"
 			" --["CMD_LINE_OPT_MULTI"]\n"
 			" --"CMD_LINE_OPT_PDUMP" "
 			"'(port=<port id> | device_id=<pci id or vdev name>),"
diff --git a/app/test-acl/main.c b/app/test-acl/main.c
index 4bc00272f4..0a5dfb621d 100644
--- a/app/test-acl/main.c
+++ b/app/test-acl/main.c
@@ -12,7 +12,7 @@
 #include <rte_lcore.h>
 #include <rte_ip.h>
 
-#define	PRINT_USAGE_START	"%s [EAL options]\n"
+#define	PRINT_USAGE_START	"%s [EAL options] --\n"
 
 #define	RTE_LOGTYPE_TESTACL	RTE_LOGTYPE_USER1
 
diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 404dba2b20..30c1753c32 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -49,7 +49,7 @@
 static void
 usage(char* progname)
 {
-	printf("usage: %s "
+	printf("usage: %s [EAL options] -- "
 #ifdef RTE_LIBRTE_CMDLINE
 	       "[--interactive|-i] "
 	       "[--cmdline-file=FILENAME] "
-- 
2.26.0

Re: [dpdk-dev] [PATCH] app: fix usage help of options separated by dashes

[Bruce Richardson]

On Tue, Apr 21, 2020 at 01:25:31AM +0200, Thomas Monjalon wrote:
> The EAL options and app-specific options are separated
> with double dashes.
> 
> The help of testpmd, test-acl and pdump were missing
> the dashes after EAL options.
> Note: testpmd was completely missing the EAL options.
> 
> Fixes: af75078fece3 ("first public release")
> Fixes: 26c057ab6c45 ("acl: new test-acl application")
> Fixes: b2854d5317e8 ("app/pdump: support multi-core capture")
> Cc: vipin.varghese@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [dpdk-dev] [PATCH] app: fix usage help of options separated by dashes

[Bruce Richardson]

On Tue, Apr 21, 2020 at 01:25:31AM +0200, Thomas Monjalon wrote:
> The EAL options and app-specific options are separated
> with double dashes.
> 
> The help of testpmd, test-acl and pdump were missing
> the dashes after EAL options.
> Note: testpmd was completely missing the EAL options.
> 
> Fixes: af75078fece3 ("first public release")
> Fixes: 26c057ab6c45 ("acl: new test-acl application")
> Fixes: b2854d5317e8 ("app/pdump: support multi-core capture")
> Cc: vipin.varghese@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [dpdk-dev] [dpdk-stable] [PATCH] app: fix usage help of options separated by dashes

[David Marchand]

On Tue, Apr 21, 2020 at 1:26 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The EAL options and app-specific options are separated
> with double dashes.
>
> The help of testpmd, test-acl and pdump were missing
> the dashes after EAL options.
> Note: testpmd was completely missing the EAL options.
>
> Fixes: af75078fece3 ("first public release")
> Fixes: 26c057ab6c45 ("acl: new test-acl application")
> Fixes: b2854d5317e8 ("app/pdump: support multi-core capture")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.


-- 
David Marchand