From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48632A00C2; Thu, 23 Apr 2020 11:06:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 234AD1D53C; Thu, 23 Apr 2020 11:06:47 +0200 (CEST) Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by dpdk.org (Postfix) with ESMTP id 80B901D50B for ; Thu, 23 Apr 2020 11:06:45 +0200 (CEST) Received: by mail-lj1-f196.google.com with SMTP id b2so5402871ljp.4 for ; Thu, 23 Apr 2020 02:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zrNCuIfn4U6SGVqdaC9dbyzKg7Irp05I8YUCp0393bc=; b=lqVzAIKvi9wxkhGuKwQpyYKvv5SaA3EuyWGaSUsqaWOLepMn2CG6p3vISQRbsKcRhl 25PxesGHKb8uIzgnBf9YQWvUGkCDT+SbnMFu9Qod67JTA8Gegcsi7upOZvZLAE8g+6/z TB6wKgNo0d0KnO3tWJXCQSGV5+khZw8lkDkDF+3Udg6H79mYvQC5WzBEgyc5KwRkTJxI HU8+lNAcjMcNmW8SLXBu5HM0s7ntxISogLmXL+Zx5Ig/kL4nRvr0mFIwYGer4k9PLFBK CwKgeWqgKcqu2uRumfFpwD6ftz/3msESEtbtdHwU9o+zWCBqRhGRQV/HYw+Ia/cEyduO cvVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zrNCuIfn4U6SGVqdaC9dbyzKg7Irp05I8YUCp0393bc=; b=M+YOlZaQLfDJ8rz4/fSgi3PqhslDyf8Kt6MYYaJi2oaBDAyMu1EudvtQRBHSUMh0y5 wvU+rFc9csjJgV98i2tmgzflU+YjxqQWvAjAvFiFeVPidXAxnCnggLU7K+qEUO6Z7i0q ODI8ZTlBTIiCkuS4j3veNUti1GiZsst1pb3KaCXc1piTM6RQAE7+t6wimvrfsXwHPH6O d8dnSEuPRijQW9Zj/3NWbl4Clag+4Os4cw/Hl0BqblvUuhr0BaJTGWNbLpcREYqR7fqA +yOkhhkeD4jFiG8kk0WODxOt0Tnr84P6mOTgef2mHgCFIpasHZZBYaE0F0ntjXW2n7H3 LEUw== X-Gm-Message-State: AGi0PuZMHhwFQiS0DT+dR5VK2biKt+z8HJNKWkcbKut3nK4tPnHfLVEw 4/QLRnW1I7rxQsIpsQmgJz4= X-Google-Smtp-Source: APiQypIaRdwysq70qZu5XlmxP7gM7iPbSnN1YLDp2eHL5M6bnEFn3wao6ApEzTY//RWRDa1aH0RIwA== X-Received: by 2002:a2e:6a08:: with SMTP id f8mr1878972ljc.8.1587632805016; Thu, 23 Apr 2020 02:06:45 -0700 (PDT) Received: from Sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id k11sm1246763lfe.44.2020.04.23.02.06.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2020 02:06:44 -0700 (PDT) Date: Thu, 23 Apr 2020 12:06:43 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: Ranjit Menon , talshn@mellanox.com, dev@dpdk.org, pallavi.kadam@intel.com, david.marchand@redhat.com, grive@u256.net Message-ID: <20200423120643.0173e2d2@Sovereign> In-Reply-To: <15414965.hlxOUv9cDv@thomas> References: <20200422072747.15960-1-talshn@mellanox.com> <20200422072747.15960-2-talshn@mellanox.com> <1248d40a-741d-69ae-a149-4e5b98691f76@intel.com> <15414965.hlxOUv9cDv@thomas> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2020-04-23 09:27 GMT+0200 Thomas Monjalon wrote: > 23/04/2020 01:51, Ranjit Menon: > > On 4/22/2020 12:27 AM, talshn@mellanox.com wrote: > > > From: Tal Shnaiderman > > > > > > Move common functions between Unix and Windows to eal_config.c. > > > > Like other files in common, we should call this eal_common_config.c > > I am not sure about the interest of repeating the directory name > in the file name in general. > Do you see a real benefit? It allows using VPATH in Makefile. If filenames are identical in different VPATH directories, make can't pick both. Makefiles are being deprecated, but they'll be around for some more time. -- Dmitry Kozlyuk