DPDK patches and discussions
 help / color / mirror / Atom feed
From: Li Feng <fengli@smartx.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, kyle@smartx.com, lifeng1519@gmail.com,
	fanyang@smartx.com, Li Feng <fengli@smartx.com>
Subject: [dpdk-dev] [PATCH v2] eal: add madvise to avoid dump memory
Date: Thu, 23 Apr 2020 23:43:01 +0800	[thread overview]
Message-ID: <20200423154302.2217041-1-fengli@smartx.com> (raw)
In-Reply-To: <20200420070508.645533-1-fengli@smartx.com>

Avoid dump all mapped memory to a core dump file when crash.
Otherwise it will very large and it's hard to analyze with gdb.

In my test, it will dump 128GiB memory to a core dump file when integrated
to spdk with default configuration.

Signed-off-by: Li Feng <fengli@smartx.com>
---
 lib/librte_eal/common/eal_common_memory.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c
index cc7d54e0c..2d9564b28 100644
--- a/lib/librte_eal/common/eal_common_memory.c
+++ b/lib/librte_eal/common/eal_common_memory.c
@@ -177,6 +177,20 @@ eal_get_virtual_area(void *requested_addr, size_t *size,
 		after_len = RTE_PTR_DIFF(map_end, aligned_end);
 		if (after_len > 0)
 			munmap(aligned_end, after_len);
+
+		/*
+		 * Exclude this pages from a core dump.
+		 */
+		if (madvise(aligned_addr, *size, MADV_DONTDUMP) != 0)
+			RTE_LOG(WARNING, EAL, "Madvise with MADV_DONTDUMP failed: %s\n",
+				strerror(errno));
+	} else {
+		/*
+		 * Exclude this pages from a core dump.
+		 */
+		if (madvise(mapped_addr, map_sz, MADV_DONTDUMP) != 0)
+			RTE_LOG(WARNING, EAL, "Madvise with MADV_DONTDUMP failed: %s\n",
+				strerror(errno));
 	}
 
 	return aligned_addr;
-- 
2.11.0


-- 
The SmartX email address is only for business purpose. Any sent message 
that is not related to the business is not authorized or permitted by 
SmartX.
本邮箱为北京志凌海纳科技有限公司(SmartX)工作邮箱. 如本邮箱发出的邮件与工作无关,该邮件未得到本公司任何的明示或默示的授权.



  parent reply	other threads:[~2020-04-23 15:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200420070508.645533-1-fengli@smartx.com>
2020-04-20  7:07 ` [dpdk-dev] [PATCH] " Li Feng
2020-04-20  7:13   ` David Marchand
2020-04-20  9:40     ` Feng Li
2020-04-21  7:41       ` David Marchand
2020-04-21 11:06         ` Feng Li
2020-04-21 12:19           ` Burakov, Anatoly
2020-04-21 16:38             ` Feng Li
2020-04-21 17:02               ` Burakov, Anatoly
2020-04-22  3:13                 ` Li Feng
2020-04-22  9:53                   ` Burakov, Anatoly
     [not found]                     ` <CAEK8JBCdfZJiKNjDNgC9nDGLni9Dvw+U1doRFnh+zkAs5TXEsg@mail.gmail.com>
2020-04-23 12:22                       ` Burakov, Anatoly
2020-04-23 15:43 ` Li Feng [this message]
2020-04-23 16:33   ` [dpdk-dev] [PATCH v2] " Burakov, Anatoly
2020-04-23 20:04     ` David Marchand
2020-04-24  9:12       ` Burakov, Anatoly
2020-04-24  9:14         ` Bruce Richardson
2020-04-24  9:33           ` Feng Li
2020-04-24 11:00             ` Burakov, Anatoly
2020-04-24 12:03               ` Li Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200423154302.2217041-1-fengli@smartx.com \
    --to=fengli@smartx.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=fanyang@smartx.com \
    --cc=kyle@smartx.com \
    --cc=lifeng1519@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).