DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Fady Bader <fady@mellanox.com>
Cc: dev@dpdk.org, thomas@monjalon.net, talshn@mellanox.com,
	dmitry.koziuk@gmail.com, harini.ramakrishnan@microsoft.com,
	ocardona@microsoft.com, anand.rawat@intel.com,
	ranjit.menon@intel.com
Subject: Re: [dpdk-dev] [PATCH 2/2] timer: support EAL functions on Windows
Date: Thu, 23 Apr 2020 18:18:38 +0300
Message-ID: <20200423181838.7e37c6c9@Sovereign> (raw)
In-Reply-To: <20200423144350.4016-3-fady@mellanox.com>

On 2020-04-23 17:43 GMT+0300 Fady Bader wrote:
[snip]
> diff --git a/lib/librte_eal/windows/eal_timer.c b/lib/librte_eal/windows/eal_timer.c
> new file mode 100644
> index 000000000..73eaff948
> --- /dev/null
> +++ b/lib/librte_eal/windows/eal_timer.c
> @@ -0,0 +1,67 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright 2020 Mellanox Technologies, Ltd
> + */
> +#include <inttypes.h>
> +#include <time.h>
> +
> +#include <rte_windows.h>
> +#include <rte_common.h>
> +#include <rte_log.h>
> +#include <rte_cycles.h>
> +#include <rte_eal.h>
> +#include <rte_errno.h>
> +
> +/* The frequency of the RDTSC timer resolution */
> +static uint64_t eal_tsc_resolution_hz;
> +
> +void
> +rte_delay_us_sleep(unsigned int us)
> +{
> +	LONGLONG ns = us * 1000;
> +	HANDLE timer;
> +	LARGE_INTEGER liDueTime;

Shouldn't Windows code follow DPDK naming conventions?

> +	/* create waitable timer */
> +	timer = CreateWaitableTimer(NULL, TRUE, NULL);
> +	if(!timer){

Missing spaces. There are more styling issues below that could be detected by
running ./devtools/checkpatches.sh.

> +		/* didnt find any better errno val */
> +		rte_errno = EINVAL;
> +		return;

ENOMEM probably indicates lack of resources better. EINVAL usually implies
wrong arguments to the function. You can also use RTE_WIN32_LOG_ERR() here to
log exact error code on debug level.

> +	}
> +
> +	/* set us microseconds time for timer */
> +	liDueTime.QuadPart = -ns;

Timeout is neither in microseconds, nor in nanoseconds, it's in 100-nanosecond
intervals.

> +	if(!SetWaitableTimer(timer, &liDueTime, 0, NULL, NULL, FALSE)){
> +		CloseHandle(timer);
> +		/* didnt find any better errno val */
> +		rte_errno = EFAULT;

And here, EINVAL is probably better, because result depends on function
argument and this probably will be the most frequent source of errors.

> +		return;
> +	}
> +	/* start wait for timer for us microseconds */
> +	WaitForSingleObject(timer, INFINITE);
> +	CloseHandle(timer);
> +}
[snip]
> diff --git a/lib/librte_eal/windows/include/rte_os.h b/lib/librte_eal/windows/include/rte_os.h
> index 62805a307..951a14d72 100644
> --- a/lib/librte_eal/windows/include/rte_os.h
> +++ b/lib/librte_eal/windows/include/rte_os.h
> @@ -24,6 +24,8 @@ extern "C" {
>  #define PATH_MAX _MAX_PATH
>  #endif
>  
> +#define sleep(x) Sleep(1000 * x)

It's better to enclose "x" in parentheses or to use inline function.

-- 
Dmitry Kozlyuk

  reply	other threads:[~2020-04-23 15:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-23 14:43 [dpdk-dev] [PATCH 0/2] eal timer split and implementation for Windows Fady Bader
2020-04-23 14:43 ` [dpdk-dev] [PATCH 1/2] timer: move from common to Unix directory Fady Bader
2020-06-17  9:39   ` [dpdk-dev] [PATCH v9 0/2] eal timer split and implementation for Windows Fady Bader
2020-06-17  9:39     ` [dpdk-dev] [PATCH v9 1/2] timer: move from common to Unix directory Fady Bader
2020-06-17  9:39     ` [dpdk-dev] [PATCH v9 2/2] timer: support EAL functions on Windows Fady Bader
2020-06-17 22:15       ` Ranjit Menon
2020-06-18  7:56         ` Fady Bader
2020-06-18  6:55   ` [dpdk-dev] [PATCH v10 0/2] eal timer split and implementation for Windows Fady Bader
2020-06-18  6:55     ` [dpdk-dev] [PATCH v10 1/2] timer: move from common to Unix directory Fady Bader
2020-06-18  6:55     ` [dpdk-dev] [PATCH v10 2/2] timer: support EAL functions on Windows Fady Bader
2020-06-18 19:32     ` [dpdk-dev] [PATCH v10 0/2] eal timer split and implementation for Windows Ranjit Menon
2020-06-23 16:19       ` Thomas Monjalon
2020-04-23 14:43 ` [dpdk-dev] [PATCH 2/2] timer: support EAL functions on Windows Fady Bader
2020-04-23 15:18   ` Dmitry Kozlyuk [this message]
2020-04-24 21:32   ` Dmitry Kozlyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200423181838.7e37c6c9@Sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=anand.rawat@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.koziuk@gmail.com \
    --cc=fady@mellanox.com \
    --cc=harini.ramakrishnan@microsoft.com \
    --cc=ocardona@microsoft.com \
    --cc=ranjit.menon@intel.com \
    --cc=talshn@mellanox.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git