From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 102B1A00C2;
	Fri, 24 Apr 2020 08:51:21 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A13961C1D3;
	Fri, 24 Apr 2020 08:51:17 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by dpdk.org (Postfix) with ESMTP id 7675E1C1D3;
 Fri, 24 Apr 2020 08:51:16 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EB83EC14;
 Thu, 23 Apr 2020 23:51:15 -0700 (PDT)
Received: from net-arm-thunderx2-02.shanghai.arm.com
 (net-arm-thunderx2-02.shanghai.arm.com [10.169.41.165])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C56833F68F;
 Thu, 23 Apr 2020 23:51:12 -0700 (PDT)
From: Ruifeng Wang <ruifeng.wang@arm.com>
To: wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, jerinj@marvell.com,
 viktorin@rehivetech.com
Cc: dev@dpdk.org, gavin.hu@arm.com, honnappa.nagarahalli@arm.com,
 juraj.linkes@pantheon.tech, nd@arm.com,
 Ruifeng Wang <ruifeng.wang@arm.com>, stable@dpdk.org
Date: Fri, 24 Apr 2020 14:50:51 +0800
Message-Id: <20200424065053.119885-2-ruifeng.wang@arm.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20200424065053.119885-1-ruifeng.wang@arm.com>
References: <20200424065053.119885-1-ruifeng.wang@arm.com>
Subject: [dpdk-dev] [PATCH 1/3] arch/arm: add vcopyq intrinsic for aarch32
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have
the intrinsic.

Fixes: 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc")
Cc: stable@dpdk.org

Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
 lib/librte_eal/arm/include/rte_vect.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/arm/include/rte_vect.h b/lib/librte_eal/arm/include/rte_vect.h
index 9287a1117..d7c8aa61e 100644
--- a/lib/librte_eal/arm/include/rte_vect.h
+++ b/lib/librte_eal/arm/include/rte_vect.h
@@ -62,7 +62,11 @@ vaddvq_u16(uint16x8_t a)
 
 #endif
 
-#if RTE_CC_IS_GNU && (GCC_VERSION < 70000)
+#if defined(RTE_ARCH_ARM) || \
+(defined(RTE_ARCH_ARM64) && RTE_CC_IS_GNU && (GCC_VERSION < 70000))
+/* NEON intrinsic vcopyq_laneq_u32() is not supported in ARMv7-A(AArch32)
+ * On AArch64, this intrinsic is supported since GCC versioin 7.
+ */
 static inline uint32x4_t
 vcopyq_laneq_u32(uint32x4_t a, const int lane_a,
 		 uint32x4_t b, const int lane_b)
-- 
2.17.1