From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3085EA00C2; Sat, 25 Apr 2020 08:11:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 99EF61C1F6; Sat, 25 Apr 2020 08:10:46 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 2D7651C1E5 for ; Sat, 25 Apr 2020 08:10:43 +0200 (CEST) IronPort-SDR: EiyM352CKN93Xl9eX2ie/Vas/1GhSRS5YkXUXEmiv9ma6qv69X784DVKJ2iwJhVuP0np03XeXO RXUTZTr2vPdA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2020 23:10:42 -0700 IronPort-SDR: ReKVz6GmOFjH/9Eyc58NJUOJfaMFOjsBsnBEsN81uLxISFI7GYveJMwHdpV6V7HoOI6SH7MB06 KZTZazntqnJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,314,1583222400"; d="scan'208";a="281099208" Received: from npg-dpdk-haiyue-3.sh.intel.com ([10.67.119.46]) by fmsmga004.fm.intel.com with ESMTP; 24 Apr 2020 23:10:41 -0700 From: Haiyue Wang To: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, nhorman@tuxdriver.com, mdr@ashroe.eu Cc: Haiyue Wang Date: Sat, 25 Apr 2020 14:04:40 +0800 Message-Id: <20200425060441.36874-6-haiyue.wang@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200425060441.36874-1-haiyue.wang@intel.com> References: <20190613142344.9188-1-nhorman@tuxdriver.com> <20200425060441.36874-1-haiyue.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v6 5/6] devtools: exempt internal ABI checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" No need to restrict the ABI on symbols that are only used by core libraries. Signed-off-by: Haiyue Wang --- devtools/check-symbol-change.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh index ed2178e36..7b6d5f40f 100755 --- a/devtools/check-symbol-change.sh +++ b/devtools/check-symbol-change.sh @@ -91,6 +91,13 @@ check_for_rule_violations() if [ "$ar" = "add" ] then + if [ "$secname" = "INTERNAL" ] + then + # these are absolved from any further checking + echo "Skipping symbol $symname in INTERNAL" + continue + fi + if [ "$secname" = "unknown" ] then # Just inform the user of this occurrence, but @@ -148,6 +155,7 @@ check_for_rule_violations() else if ! grep -q "$mname $symname .* add" "$mapdb" && \ + [ "$secname" != "INTERNAL" ] && \ [ "$secname" != "EXPERIMENTAL" ] then # Just inform users that non-experimenal -- 2.26.2