From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4BE8A00C2; Sat, 25 Apr 2020 16:02:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A13A41C1F7; Sat, 25 Apr 2020 16:01:55 +0200 (CEST) Received: from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com [192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 63ACC1C1B3 for ; Sat, 25 Apr 2020 16:01:49 +0200 (CEST) Received: from mail-irv-17.broadcom.com (mail-irv-17.lvn.broadcom.net [10.75.242.48]) by rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 848D330C025; Sat, 25 Apr 2020 06:49:57 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 848D330C025 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1587822597; bh=RQwzet1N9ah8NS6o/b8//pG+4V3odqTyVONd6xwwWNs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uzw+FFFHDyijK9pZfX5Rp5bEgOs0yf3nHRfqiis83xpz36uobl5dXtV7DOiDQadXo 5gvDNXGi+sjQAK5B4nWPmrwdeHFlY8ZMTmdus2rnW64NfRSdkmsAjv30EBxQCp4bH4 NVdfyp8EtJFQ/guUTdgYZr9YNxY1u9t6Xx7XmAGs= Received: from localhost.localdomain (unknown [10.230.185.215]) by mail-irv-17.broadcom.com (Postfix) with ESMTP id BD52514008B; Sat, 25 Apr 2020 07:01:47 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: Shahaji Bhosle , Randy Schacher , Venkat Duvvuru , Mike Baucom Date: Sat, 25 Apr 2020 07:01:41 -0700 Message-Id: <20200425140141.27947-5-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200425140141.27947-1-ajit.khaparde@broadcom.com> References: <1587786446-35230-1-git-send-email-venkatkumar.duvvuru@broadcom.com> <20200425140141.27947-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 4/4] net/bnxt: add truflow flush-timer to alloc table scope API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Shahaji Bhosle Updated the params list to include flush timer, this will allow users to set the HW flush timer value in 10th of second. Setting 0 will disable the pending cache flush feature. Signed-off-by: Shahaji Bhosle Signed-off-by: Randy Schacher Signed-off-by: Venkat Duvvuru Reviewed-by: Mike Baucom Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_core.h | 6 ++++++ drivers/net/bnxt/tf_core/tf_msg.c | 3 +++ drivers/net/bnxt/tf_core/tf_msg.h | 1 + drivers/net/bnxt/tf_core/tf_tbl.c | 1 + drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 6 ++++++ 5 files changed, 17 insertions(+) diff --git a/drivers/net/bnxt/tf_core/tf_core.h b/drivers/net/bnxt/tf_core/tf_core.h index 4b60973ee..1eedd80e7 100644 --- a/drivers/net/bnxt/tf_core/tf_core.h +++ b/drivers/net/bnxt/tf_core/tf_core.h @@ -560,6 +560,12 @@ struct tf_alloc_tbl_scope_parms { * [in] Brd4 only receive table access interface id */ uint32_t tx_tbl_if_id; + /** + * [in] Flush pending HW cached flows every 1/10th of value + * set in seconds, both idle and active flows are flushed + * from the HW cache. If set to 0, this feature will be disabled. + */ + uint8_t hw_flow_cache_flush_timer; /** * [out] table scope identifier */ diff --git a/drivers/net/bnxt/tf_core/tf_msg.c b/drivers/net/bnxt/tf_core/tf_msg.c index bdf8f155f..beecafdeb 100644 --- a/drivers/net/bnxt/tf_core/tf_msg.c +++ b/drivers/net/bnxt/tf_core/tf_msg.c @@ -978,6 +978,7 @@ int tf_msg_em_cfg(struct tf *tfp, uint16_t key1_ctx_id, uint16_t record_ctx_id, uint16_t efc_ctx_id, + uint8_t flush_interval, int dir) { int rc; @@ -993,6 +994,8 @@ int tf_msg_em_cfg(struct tf *tfp, req.flags = tfp_cpu_to_le_32(flags); req.num_entries = tfp_cpu_to_le_32(num_entries); + req.flush_interval = flush_interval; + req.key0_ctx_id = tfp_cpu_to_le_16(key0_ctx_id); req.key1_ctx_id = tfp_cpu_to_le_16(key1_ctx_id); req.record_ctx_id = tfp_cpu_to_le_16(record_ctx_id); diff --git a/drivers/net/bnxt/tf_core/tf_msg.h b/drivers/net/bnxt/tf_core/tf_msg.h index b8d8c1ede..030d1881e 100644 --- a/drivers/net/bnxt/tf_core/tf_msg.h +++ b/drivers/net/bnxt/tf_core/tf_msg.h @@ -152,6 +152,7 @@ int tf_msg_em_cfg(struct tf *tfp, uint16_t key1_ctx_id, uint16_t record_ctx_id, uint16_t efc_ctx_id, + uint8_t flush_interval, int dir); /** diff --git a/drivers/net/bnxt/tf_core/tf_tbl.c b/drivers/net/bnxt/tf_core/tf_tbl.c index 236affe25..93f387e86 100644 --- a/drivers/net/bnxt/tf_core/tf_tbl.c +++ b/drivers/net/bnxt/tf_core/tf_tbl.c @@ -1500,6 +1500,7 @@ tf_alloc_eem_tbl_scope(struct tf *tfp, em_tables[KEY1_TABLE].ctx_id, em_tables[RECORD_TABLE].ctx_id, em_tables[EFC_TABLE].ctx_id, + parms->hw_flow_cache_flush_timer, dir); if (rc) { PMD_DRV_LOG(ERR, diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c index f8047f0d6..a9cc92d34 100644 --- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c +++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c @@ -121,6 +121,12 @@ bnxt_init_tbl_scope_parms(struct bnxt *bp, else dparms = bnxt_ulp_device_params_get(dev_id); + /* + * Set the flush timer for EEM entries. The value is in 100ms intervals, + * so 100 is 10s. + */ + params->hw_flow_cache_flush_timer = 100; + if (!dparms) { params->rx_max_key_sz_in_bits = BNXT_ULP_DFLT_RX_MAX_KEY; params->rx_max_action_entry_sz_in_bits = -- 2.21.1 (Apple Git-122.3)