From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6ABFA00C5; Sun, 26 Apr 2020 14:02:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E11A1C042; Sun, 26 Apr 2020 14:02:06 +0200 (CEST) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id 8B4C11C037 for ; Sun, 26 Apr 2020 14:02:04 +0200 (CEST) Received: by mail-lj1-f194.google.com with SMTP id a21so14566519ljb.9 for ; Sun, 26 Apr 2020 05:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RJr1V+d+M6rrlKq+JyOiu4wEwerqVUvMPYUSn/t28kw=; b=DYWUlyb5G1paMWgfjwkojD8Lqnvj9uj9uta1JsFeiJ/73j0Yc/tXzQ1dtRycEdqY3d HGmSGGAxTIiQT4hVIdp59yIv7iM+iGH1zSnRbdFhe6KdsM6nm1WO9Qfc4ZWzJvXCZFvV o+IDbYnSYB8/k8wCfQ3eoOJ0GCuuoSIe/8gMaMyGrcaxbEWbciONzFTKshj2+7OJZu2o qB6PCToQ9Jo5qJF3u+1rSIVbC+jzaBbRTypfQ66MHOiGb/Q8CF+x0L3/uVx0/THTG8GW HREcjRfjhnZL/ZEqCsuE+m1dugFKrYBT9ylpKU6Sk+sr8t3YQI3j1ksyVZZrM3V8jTZN 5d9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RJr1V+d+M6rrlKq+JyOiu4wEwerqVUvMPYUSn/t28kw=; b=lua1YzSQHV5WH8sliIJ/dJhV3hPzFMQwfi2c3LsaRrqxc6Cjj9eL0o9P317KyGSgRT o71iAzYV5TrVC5HAvLBLy1Eng2eagFlI9Zel3I+mMGuCNc2eHomHtUrtwgfnxOIfdK0h AOVT9ifxS+ZMMPScyA1J9ZRd6SpHzwDqOhOSQdcO2IhMB6UborBaPTN5av5LIkdarYSZ hZS92aTrUwZZV74x0u16MQSh/W1d9G6yhADRdsK96WV63zDxtEMC76hgM+xSPYLGiiLM KlzctqV8hx99er4sxaTVu+6DK4Hio9/ONqPC6cilQQhzRxVJXQbeOXID04VCh8h14b51 iJcw== X-Gm-Message-State: AGi0Pubx0n+IcLrwTH0XbDrNM1bHNEnzh5sPk/Nd4wLXgNDLuD7uu+sw NeSRb/e7CGzpQhBQ1hVDctE= X-Google-Smtp-Source: APiQypIy19L5rf7lY75dJzZQhxXVySXV8ghd1FAQkQ9bj/qRRWXmPAZzBqRzvckuGg86ZLImuviaYw== X-Received: by 2002:a2e:9055:: with SMTP id n21mr11568822ljg.46.1587902524022; Sun, 26 Apr 2020 05:02:04 -0700 (PDT) Received: from Sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id w27sm10075040lfn.45.2020.04.26.05.02.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Apr 2020 05:02:03 -0700 (PDT) Date: Sun, 26 Apr 2020 15:02:02 +0300 From: Dmitry Kozlyuk To: Jerin Jacob Cc: dpdk-dev , Pallavi Kadam , Narcisa Ana Maria Vasile , Ranjit Menon , Thomas Monjalon , Jerin Jacob , Sunil Kumar Kori , Bruce Richardson , Harini Ramakrishnan , Omar Cardona , David Marchand Message-ID: <20200426150202.521e7930@Sovereign> In-Reply-To: References: <20200426032245.2437733-1-dmitry.kozliuk@gmail.com> <20200426032245.2437733-3-dmitry.kozliuk@gmail.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] eal/windows: fix build by supporting trace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2020-04-26 17:02 GMT+0530 Jerin Jacob wrote: > > +/** > > + * Get absolute path to the directory where permanent data can be stored. > > + * > > + * @return > > + * Statically allocated string on success, NULL on failure. > > + */ > > +const char * > > +eal_permanent_data_path(void); > > Do windows have PATH_MAX kind of macro? I think, it is better API > consumer allocates > the memory of size PATH_MAX and implementation fills it, instead of, > the static scheme. This API falls in line with rte_eal_get_runtime_dir() and other eal_filesystem.h functions, that use static scheme. Logically, its result never changes. It is race-free and is only called during initialization. What you propose can be done, but are there any benefits? While we're at it, don't these declarations belong to eal_filesystem.h? I left them in eal_private.h, because eal_filesystem.h is mostly Unix-specific. -- Dmitry Kozlyuk