From: Sunil Kumar Kori <skori@marvell.com>
To: Jerin Jacob <jerinj@marvell.com>, Sunil Kumar Kori <skori@marvell.com>
Cc: <dev@dpdk.org>
Subject: [dpdk-dev] [PATCH] eal/trace: fix coverity issues
Date: Mon, 27 Apr 2020 17:34:24 +0530 [thread overview]
Message-ID: <20200427120424.22728-1-skori@marvell.com> (raw)
Pointer was being dereferenced without NULL checking.
Coverity issue: 357768
Fixes: 8c8066ea6a7b ("trace: add trace mode configuration parameter")
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
lib/librte_eal/common/eal_common_trace_utils.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/eal_common_trace_utils.c b/lib/librte_eal/common/eal_common_trace_utils.c
index fce8892c3..119e97119 100644
--- a/lib/librte_eal/common/eal_common_trace_utils.c
+++ b/lib/librte_eal/common/eal_common_trace_utils.c
@@ -227,15 +227,16 @@ int
eal_trace_mode_args_save(const char *optarg)
{
struct trace *trace = trace_obj_get();
- size_t len = strlen(optarg);
unsigned long tmp;
char *pattern;
+ size_t len;
if (optarg == NULL) {
trace_err("no optarg is passed");
return -EINVAL;
}
+ len = strlen(optarg);
if (len == 0) {
trace_err("value is not provided with option");
return -EINVAL;
--
2.17.1
next reply other threads:[~2020-04-27 12:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 12:04 Sunil Kumar Kori [this message]
2020-04-27 12:26 ` David Marchand
2020-04-27 13:46 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-04-27 13:52 ` David Marchand
2020-04-27 14:00 ` Sunil Kumar Kori
2020-04-30 13:59 ` Sunil Kumar Kori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427120424.22728-1-skori@marvell.com \
--to=skori@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).