From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F15DA00BE; Tue, 28 Apr 2020 01:28:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7185E1D52F; Tue, 28 Apr 2020 01:28:35 +0200 (CEST) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) by dpdk.org (Postfix) with ESMTP id 488701D483 for ; Tue, 28 Apr 2020 01:28:33 +0200 (CEST) Received: by mail-pj1-f66.google.com with SMTP id fu13so292169pjb.5 for ; Mon, 27 Apr 2020 16:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gM9D22B7a/TuqnZw8T9M6yRj21fpxqioBW632jm56kU=; b=CZnfGzfbz3FXaObYfarrbPbBH4mDRWfde14UR2J4EusttzZWK/+vYvmi6LnNTCNnck uc2jMMNTNe1I+XYJql+W2oCLsosdjMnLTyz8bCYkC66/TQGfIUkei8B2SwWKFFHk34lN Entoots3pyYS/B8fyWQRFqVs0Z0LI+uOyGYWHiDquZtJ3QcwBK8n+G1GicCZagwDUWm6 k7PLz6LVzpJYb9BX2Pbmktqd9F3ztStzOE2Cg05Tqirb36U8suOz83UNbBp4nyHx2vu4 bpTKBokCcbKGjqdLmhEd3KHiIoIANXzciuKuxsuHObm6m4zAawxmiJCrNoeC5DQmK3nm 317g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gM9D22B7a/TuqnZw8T9M6yRj21fpxqioBW632jm56kU=; b=jEf3T70plFMAazghKqwBZz63KaSgp0QTQznTCL44fuAcJ3LRPAHMZ+tlv3tE+/pUJb FZTgxKJuOlpxoAtuGYTEzGgCJ6C4Dro8ztXcsteB1Xhw0nq+mwviW+PHFeAUjYSNd+H6 Wf4i9Ee2pfLt6pU/QBMSmemYxYoWJVdz0jZdlaoaAeXc2i0CNc3IJdJ3vmdZ9fGYR2Xh zyBO3flcayprSFi0tfElBnoxHsdksXVupR8QSqTVKATc87h78u55ajB3uyIQofPMaTjm X8wTB3uJBQF85q2yo6IfgVvOwzdhdyaLvKcoN/+uzxv+XRkEgVUpCOAcil56mJBBLzpC 3B4g== X-Gm-Message-State: AGi0Pua1+OCqaogGGj87S3a4Af58EPZZ1VSOyEHqbFihU2wE4smcQryc rwRU9knoohLXHBYdo4DZdGBLw1ksal8= X-Google-Smtp-Source: APiQypKoNOskxniJA8sXKTe8Z7mI/WXoDnloT7nPuflZhPsQB9BPNjM33GBm4QDDONkuIm/Ge43P1g== X-Received: by 2002:a17:90a:730a:: with SMTP id m10mr1431443pjk.9.1588030112037; Mon, 27 Apr 2020 16:28:32 -0700 (PDT) Received: from hermes.corp.microsoft.com (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z28sm13797586pfr.3.2020.04.27.16.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2020 16:28:31 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 27 Apr 2020 16:28:19 -0700 Message-Id: <20200427232822.21695-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200427232822.21695-1-stephen@networkplumber.org> References: <20200427232822.21695-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 1/4] net/vmbus: add missing barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The check for event ring being empty needs a barrier to avoid any over agressive optimization. This is same barrier as Linux kernel. Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/vmbus_channel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/vmbus/vmbus_channel.c b/drivers/bus/vmbus/vmbus_channel.c index 46b3ba3f9f9e..ff2985c25758 100644 --- a/drivers/bus/vmbus/vmbus_channel.c +++ b/drivers/bus/vmbus/vmbus_channel.c @@ -199,6 +199,7 @@ bool rte_vmbus_chan_rx_empty(const struct vmbus_channel *channel) { const struct vmbus_br *br = &channel->rxbr; + rte_smp_rmb(); return br->vbr->rindex == br->vbr->windex; } -- 2.20.1