From: talshn@mellanox.com
To: dev@dpdk.org
Cc: thomas@monjalon.net, pallavi.kadam@intel.com,
dmitry.kozliuk@gmail.com, david.marchand@redhat.com,
grive@u256.net, ranjit.menon@intel.com,
navasile@linux.microsoft.com,
Tal Shnaiderman <talshn@mellanox.com>
Subject: [dpdk-dev] [PATCH v2 5/7] drivers: fix incorrect meson import folder for Windows
Date: Tue, 28 Apr 2020 12:11:09 +0300 [thread overview]
Message-ID: <20200428091111.13416-6-talshn@mellanox.com> (raw)
In-Reply-To: <20200428091111.13416-1-talshn@mellanox.com>
From: Tal Shnaiderman <talshn@mellanox.com>
import library (/IMPLIB) in meson.build should use
the 'drivers' and not 'libs' folder.
The error is: fatal error LNK1149: output filename matches input filename.
The fix uses the correct folder.
Fixes: 5ed3766981 ("drivers: process shared link dependencies as for libs")
Signed-off-by: Tal Shnaiderman <talshn@mellanox.com>
---
drivers/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/meson.build b/drivers/meson.build
index a540117b6..d07360d27 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -162,7 +162,7 @@ foreach class:dpdk_driver_classes
lk_deps = [version_map, def_file]
if is_windows
lk_args = ['-Wl,/def:' + def_file.full_path(),
- '-Wl,/implib:lib\\' + implib]
+ '-Wl,/implib:drivers\\' + implib]
else
lk_args = ['-Wl,--version-script=' + version_map]
# on unix systems check the output of the
--
2.16.1.windows.4
next prev parent reply other threads:[~2020-04-28 9:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 9:11 [dpdk-dev] [PATCH v2 0/7] Windows bus/pci support talshn
2020-04-28 9:11 ` [dpdk-dev] [PATCH v2 1/7] eal: move OS common functions to single file talshn
2020-04-28 9:11 ` [dpdk-dev] [PATCH v2 2/7] pci: build on Windows talshn
2020-04-28 23:52 ` Dmitry Kozlyuk
2020-04-28 9:11 ` [dpdk-dev] [PATCH v2 3/7] eal: add function finding integer in a string talshn
2020-04-28 9:11 ` [dpdk-dev] [PATCH v2 4/7] drivers: ignore pmdinfogen generation for Windows talshn
2020-04-28 9:11 ` talshn [this message]
2020-04-28 9:11 ` [dpdk-dev] [PATCH v2 6/7] bus/pci: introduce Windows support with stubs talshn
2020-04-28 9:11 ` [dpdk-dev] [PATCH v2 7/7] bus/pci: support Windows with bifurcated drivers talshn
2020-04-29 0:01 ` Dmitry Kozlyuk
2020-05-03 11:53 ` Tal Shnaiderman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428091111.13416-6-talshn@mellanox.com \
--to=talshn@mellanox.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=grive@u256.net \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).