From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: qiming.yang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/ice/base: fix DCF switch rule
Date: Wed, 29 Apr 2020 15:45:59 +0800 [thread overview]
Message-ID: <20200429074559.GG6502@intel.com> (raw)
In-Reply-To: <20200423130704.37332-1-qi.z.zhang@intel.com>
On 04/23, Qi Zhang wrote:
>1. ln_en bit should not be turned on, since we only support Rx VEB.
>2. lan_en bit need to be turn on for a DCF switch rule, otherwise
> any Tx packet that hit on a rule will be dropped.
>
>Fixes: fed0c5ca5f19 ("net/ice/base: support programming a new switch recipe")
Cc: stable@dpdk.org
>
>Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>---
>v2:
>- fix a bug
>
> drivers/net/ice/base/ice_switch.c | 11 ++++++++++-
> drivers/net/ice/ice_switch_filter.c | 1 +
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c
>index fd2cf101a..0970ffdd0 100644
>--- a/drivers/net/ice/base/ice_switch.c
>+++ b/drivers/net/ice/base/ice_switch.c
>@@ -1938,6 +1938,13 @@ static void ice_fill_sw_info(struct ice_hw *hw, struct ice_fltr_info *fi)
> {
> fi->lb_en = false;
> fi->lan_en = false;
>+
>+ if ((fi->flag & ICE_FLTR_RX) &&
>+ (fi->fltr_act == ICE_FWD_TO_VSI ||
>+ fi->fltr_act == ICE_FWD_TO_VSI_LIST) &&
>+ fi->lkup_type == ICE_SW_LKUP_LAST)
>+ fi->lan_en = true;
>+
> if ((fi->flag & ICE_FLTR_TX) &&
> (fi->fltr_act == ICE_FWD_TO_VSI ||
> fi->fltr_act == ICE_FWD_TO_VSI_LIST ||
>@@ -6453,6 +6460,7 @@ ice_adv_add_update_vsi_list(struct ice_hw *hw,
> return status;
>
> ice_memset(&tmp_fltr, 0, sizeof(tmp_fltr), ICE_NONDMA_MEM);
>+ tmp_fltr.flag = m_entry->rule_info.sw_act.flag;
> tmp_fltr.fltr_rule_id = cur_fltr->fltr_rule_id;
> tmp_fltr.fltr_act = ICE_FWD_TO_VSI_LIST;
> tmp_fltr.fwd_id.vsi_list_id = vsi_list_id;
>@@ -6615,7 +6623,7 @@ ice_add_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
> s_rule = (struct ice_aqc_sw_rules_elem *)ice_malloc(hw, rule_buf_sz);
> if (!s_rule)
> return ICE_ERR_NO_MEMORY;
>- act |= ICE_SINGLE_ACT_LB_ENABLE | ICE_SINGLE_ACT_LAN_ENABLE;
>+ act |= ICE_SINGLE_ACT_LAN_ENABLE;
> switch (rinfo->sw_act.fltr_act) {
> case ICE_FWD_TO_VSI:
> act |= (rinfo->sw_act.fwd_id.hw_vsi_id <<
>@@ -6780,6 +6788,7 @@ ice_adv_rem_update_vsi_list(struct ice_hw *hw, u16 vsi_handle,
> return status;
>
> ice_memset(&tmp_fltr, 0, sizeof(tmp_fltr), ICE_NONDMA_MEM);
>+ tmp_fltr.flag = fm_list->rule_info.sw_act.flag;
> tmp_fltr.fltr_rule_id = fm_list->rule_info.fltr_rule_id;
> fm_list->rule_info.sw_act.fltr_act = ICE_FWD_TO_VSI;
> tmp_fltr.fltr_act = ICE_FWD_TO_VSI;
>diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
>index 55a5618a7..8b007b7eb 100644
>--- a/drivers/net/ice/ice_switch_filter.c
>+++ b/drivers/net/ice/ice_switch_filter.c
>@@ -1129,6 +1129,7 @@ ice_switch_parse_dcf_action(const struct rte_flow_action *actions,
> }
>
> rule_info->sw_act.src = rule_info->sw_act.vsi_handle;
>+ rule_info->sw_act.flag = ICE_FLTR_RX;
> rule_info->rx = 1;
> rule_info->priority = 5;
>
>--
>2.13.6
>
Applied to dpdk-next-net-intel with qiming's ack, Thanks.
prev parent reply other threads:[~2020-04-29 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 13:07 Qi Zhang
2020-04-29 7:44 ` Yang, Qiming
2020-04-29 7:45 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429074559.GG6502@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).