From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CBF7A00C5; Thu, 30 Apr 2020 07:54:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F3EB91D92C; Thu, 30 Apr 2020 07:54:37 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8F7311D92B for ; Thu, 30 Apr 2020 07:54:36 +0200 (CEST) IronPort-SDR: g7HsaMegvUkiDjSnzvHUbomD6nljvncit8r5IRu1pXG0r8spvpuCUeGSl+nmui3CKXsLGtJeWi xPADgdAs8wZw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 22:54:35 -0700 IronPort-SDR: F9bzTPTT1i9SfPHPfZiMqi/PwwploTTsJRlPr3d2X6jkFTPnarj2G+yIkfr+rMZ60Xl/qbOZAS iIzcv6mrchsQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,334,1583222400"; d="scan'208";a="261661237" Received: from npg-dpdk-haiyue-1.sh.intel.com ([10.67.119.213]) by orsmga006.jf.intel.com with ESMTP; 29 Apr 2020 22:54:32 -0700 From: Haiyue Wang To: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com, bruce.richardson@intel.com, anatoly.burakov@intel.com, nhorman@tuxdriver.com, mdr@ashroe.eu Cc: Haiyue Wang Date: Thu, 30 Apr 2020 13:46:05 +0800 Message-Id: <20200430054606.92715-1-haiyue.wang@intel.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v1 1/2] devtools: add internal ABI version check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" INTERNAL is new introduced version, update the shell script that checks whether built libraries are versioned with expected ABI (current ABI, current ABI + 1, EXPERIMENTAL, or INTERNAL). Signed-off-by: Haiyue Wang --- devtools/check-abi-version.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/devtools/check-abi-version.sh b/devtools/check-abi-version.sh index 9a3d13546..f0cca42a9 100755 --- a/devtools/check-abi-version.sh +++ b/devtools/check-abi-version.sh @@ -4,7 +4,7 @@ # Check whether library symbols have correct # version (provided ABI number or provided ABI -# number + 1 or EXPERIMENTAL). +# number + 1 or EXPERIMENTAL or INTERNAL). # Args: # $1: path of the library .so file # $2: ABI major version number to check @@ -12,7 +12,7 @@ if [ -z "$1" ]; then echo "Script checks whether library symbols have" - echo "correct version (ABI_VER/ABI_VER+1/EXPERIMENTAL)" + echo "correct version (ABI_VER/ABI_VER+1/EXPERIMENTAL/INTERNAL)" echo "Usage:" echo " $0 SO_FILE_PATH [ABI_VER]" exit 1 @@ -41,11 +41,11 @@ for SYM in $(echo "${OBJ_DUMP_OUTPUT}" | awk '{print $(NF-1) "-" $NF}') do version=$(echo $SYM | cut -d'-' -f 1) symbol=$(echo $SYM | cut -d'-' -f 2) - case $version in (*"$ABIVER"*|*"$NEXT_ABIVER"*|"EXPERIMENTAL") + case $version in (*"$ABIVER"*|*"$NEXT_ABIVER"*|"EXPERIMENTAL"|"INTERNAL") ;; (*) echo "Warning: symbol $symbol ($version) should be annotated " \ - "as ABI version $ABIVER / $NEXT_ABIVER, or EXPERIMENTAL." + "as ABI version $ABIVER / $NEXT_ABIVER, EXPERIMENTAL, or INTERNAL." ret=1 ;; esac -- 2.26.2