From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9DCDEA00C5; Thu, 30 Apr 2020 12:23:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 56CB71DB28; Thu, 30 Apr 2020 12:23:25 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7A1B71DB25 for ; Thu, 30 Apr 2020 12:23:23 +0200 (CEST) IronPort-SDR: 9i/JLhiHt4IgE/3FPtadDRXfg9Tlu03EoXawuDuvGGSUhcWz3M5o+oZ+Oo4yMkYRrfn3XYtQDg PEzcEBEX5O7w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2020 03:23:22 -0700 IronPort-SDR: kq2iOVAkVTLq//zI5WokVEMSpkAtm7AjQofMPwBiZpfBwEjSdWIkX9xORuMhLBk20uzBMlT4CK E+LNvbhBSK8A== X-IronPort-AV: E=Sophos;i="5.73,334,1583222400"; d="scan'208";a="459889006" Received: from bricha3-mobl.ger.corp.intel.com ([10.214.197.180]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 30 Apr 2020 03:23:18 -0700 Date: Thu, 30 Apr 2020 11:23:13 +0100 From: Bruce Richardson To: Ferruh Yigit Cc: Marvin Liu , maxime.coquelin@redhat.com, xiaolong.ye@intel.com, zhihong.wang@intel.com, dev@dpdk.org, Luca Boccassi Message-ID: <20200430102313.GA1919@bricha3-MOBL.ger.corp.intel.com> References: <20200313174230.74661-1-yong.liu@intel.com> <20200428083255.110046-1-yong.liu@intel.com> <20200428083255.110046-7-yong.liu@intel.com> <9b7b1e13-bfa1-7364-ed43-c5d81a379a43@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9b7b1e13-bfa1-7364-ed43-c5d81a379a43@intel.com> Subject: Re: [dpdk-dev] [PATCH v11 6/9] net/virtio: add vectorized packed ring Rx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 30, 2020 at 10:48:35AM +0100, Ferruh Yigit wrote: > On 4/28/2020 9:32 AM, Marvin Liu wrote: > > Optimize packed ring Rx path with SIMD instructions. Solution of > > optimization is pretty like vhost, is that split path into batch and > > single functions. Batch function is further optimized by AVX512 > > instructions. Also pad desc extra structure to 16 bytes aligned, thus > > four elements will be saved in one batch. > > > > Signed-off-by: Marvin Liu > > Reviewed-by: Maxime Coquelin > > <...> > > > @@ -9,6 +9,20 @@ sources += files('virtio_ethdev.c', > > deps += ['kvargs', 'bus_pci'] > > > > if arch_subdir == 'x86' > > + if '-mno-avx512f' not in machine_args > > + if cc.has_argument('-mavx512f') and cc.has_argument('-mavx512vl') and cc.has_argument('-mavx512bw') > > + cflags += ['-mavx512f', '-mavx512bw', '-mavx512vl'] > > + cflags += ['-DCC_AVX512_SUPPORT'] > > + if (toolchain == 'gcc' and cc.version().version_compare('>=8.3.0')) > > + cflags += '-DVHOST_GCC_UNROLL_PRAGMA' > > + elif (toolchain == 'clang' and cc.version().version_compare('>=3.7.0')) > > + cflags += '-DVHOST_CLANG_UNROLL_PRAGMA' > > + elif (toolchain == 'icc' and cc.version().version_compare('>=16.0.0')) > > + cflags += '-DVHOST_ICC_UNROLL_PRAGMA' > > + endif > > + sources += files('virtio_rxtx_packed_avx.c') > > + endif > > + endif > > This is giving following error in Travis build [1], it is seems this usage is > supported since meson 0.49 [2] and Travis has 0.47 [3], also DPDK supports > version 0.47.1+ [4]. > > Can you please check for meson v0.47 version way of doing same thing? > > .contains() is probably what you want. /Bruce