From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BBBB4A00C5; Thu, 30 Apr 2020 09:30:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F1CE21D94C; Thu, 30 Apr 2020 09:30:55 +0200 (CEST) Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by dpdk.org (Postfix) with ESMTP id 875411D94B for ; Thu, 30 Apr 2020 09:30:54 +0200 (CEST) Received: by mail-lj1-f178.google.com with SMTP id j3so5345965ljg.8 for ; Thu, 30 Apr 2020 00:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2mriUtBaCecxJd+QQ5ALIRPKXr5VVLXMP7DzBhyogrg=; b=Okb3+Pi5OtQ3DEsFn9RUyoZmg8AQu12SSiURzTo3ykYvvFojDGA65Oql3YfsWXpKkk DcRzC4R78rKwh9Onyeiyijs1+kT4ZHczsroY9dVvKhPZ9ltlTQphWO2uyNIvf9KRqWHt uENBGgQKrJReprU6zZJn4H1bXvR4mjxYPimtcoIyS7oCZNWix8arkqbNDhwGHbvuJef9 VkA/K/UETMTmP/XWDQfOI4qhuRfe2KahjlKLzkqKM0rkstalts0MWS5czTx1YZM0LoXi UkIwB1zbKt9ICLE2I9dbrbbECZn9rVQKwrr1fzhuyXea+k1Rh2zLNuBr/ri7mXzta6rE nKWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2mriUtBaCecxJd+QQ5ALIRPKXr5VVLXMP7DzBhyogrg=; b=imfILPgZcsnXC+5ZnJ8KMLih9IYme+9B8906sCSSwReuXKfNRvhURZiUIVJkTl/1WT /AldVd/WGFg7FBpQBHEdEkvnqen9IvbYr859xAi2gaGVxcbrzPaceN8B+sLvQsXfHFK2 WDL9jGWZ4Yi0abPvS6URc76JJ6SM0bwuC5R+Wl+zm94ysMUUvwHdYFfR16bW0UOOmL0F +wF3nvqrnmD95e3T/TnTPexSc81P8CDgb6+dtueQ56OPCDxDYexURZpnZ+xJCUknPsaR n93rPybrGHf5MNLVjpKvjgbrojuZA/Nu0wlWD5XyQY4daJKr6Aw0FZw5eozD/6NNwSGV tF4w== X-Gm-Message-State: AGi0Pub+FJNbE8P2QJyGvaWq7DX5DgWazhuNHFK0xh68pxs5686e72Hq FARh/le8uYZgOjSxUgK375Q= X-Google-Smtp-Source: APiQypKjt12mIWqhQNPhvjtr81Z1AZlgsCxBLj3f0dq2TMv96xu0MI4vNHCD6m693GpfxWISkEpmmg== X-Received: by 2002:a2e:3809:: with SMTP id f9mr1295216lja.281.1588231853902; Thu, 30 Apr 2020 00:30:53 -0700 (PDT) Received: from Sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id t5sm4196814lfc.69.2020.04.30.00.30.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2020 00:30:53 -0700 (PDT) Date: Thu, 30 Apr 2020 10:30:51 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: Pallavi Kadam , dev@dpdk.org, ranjit.menon@intel.com, Harini.Ramakrishnan@microsoft.com, Narcisa.Vasile@microsoft.com, tbashar@mellanox.com Message-ID: <20200430103051.5df8b23a@Sovereign> In-Reply-To: <1826663.L1bRAqqpGC@thomas> References: <20200429232427.7112-1-pallavi.kadam@intel.com> <20200429232427.7112-3-pallavi.kadam@intel.com> <1826663.L1bRAqqpGC@thomas> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] eal: add fnmatch implementation on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2020-04-30 08:52 GMT+0200 Thomas Monjalon wrote: > 30/04/2020 01:24, Pallavi Kadam: > > Added fnmatch implementation on Windows to support > > log level arguments. > > The source file is with BSD-3-Clause license. > > https://github.com/lattera/freebsd/blob/master/usr.bin/csup/fnmatch.c > > Sorry for the naive question, I don't know Windows programming. > > Do we really need this external code? > Why RtlIsNameInExpression from Windows cannot be used? > https://docs.microsoft.com/en-us/windows/win32/devnotes/rtlisnameinexpression The general reason not to use Win32 API for globbing is poorly documented contract: what are the exact matching rules? They're definitely incompatible with fnmatch(3). IMO small external code is better than unknown behavior. RtlIsNameInExpression is an internal call for drivers and services with a cumbersome API. PathMatchSpecA is the user-mode interface, but see above. https://docs.microsoft.com/en-us/windows/win32/api/shlwapi/nf-shlwapi-pathmatchspeca -- Dmitry Kozlyuk