From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71C50A04AF; Mon, 4 May 2020 15:44:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F3BC81D159; Mon, 4 May 2020 15:44:37 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 117CF1D158 for ; Mon, 4 May 2020 15:44:36 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 044DaVMP032284; Mon, 4 May 2020 06:44:36 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0818; bh=VtjMd+UQfi7uwBzL8qMx3g6T2QtNZebYAwll0b1998E=; b=ScSV1vsUDV9HmTyiSqF1TBibSrjUwf3jz9Q5iN2XOskvAGB7xJvO7lcjku939N9TamOx aEyewpbfVOBvWb9vHASth/3vPTZP7uMtkJ+LKMv6hygAuufiUcydFPQy83ZNJYQfEomb 4mCpeo6lcFD6auyKmwSXvSjSpey/shVNUQ4z1RpMkqEs7/g9a5eWKiJKHqdMlATlB6g2 N2L8UrFkEG8ijU4lDFKDUUokUyZA43AcbsqEir/iGXvdJCAFcEnYt6Pt5bA0lY1eMbIR HCY1vkTB8Um0vYggMFb+dDJLMp/r/yQqOE4evReQiM9Ai8TNJ7o0wgB0HI4LZnsT3zxq 7Q== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 30s67q6xac-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 04 May 2020 06:44:36 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 4 May 2020 06:44:34 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 4 May 2020 06:44:34 -0700 Received: from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14]) by maili.marvell.com (Postfix) with ESMTP id 44E5E3F703F; Mon, 4 May 2020 06:44:33 -0700 (PDT) From: To: Thomas Monjalon CC: , , Jerin Jacob Date: Mon, 4 May 2020 19:15:37 +0530 Message-ID: <20200504134537.3683158-1-jerinj@marvell.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200412150427.2786199-1-jerinj@marvell.com> References: <20200412150427.2786199-1-jerinj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-05-04_07:2020-05-04, 2020-05-04 signatures=0 Subject: [dpdk-dev] [PATCH v3] doc: use glob terminology X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Jerin Jacob Glob is the terminology used in fnmatch man page. Use glob terminology across DPDK for shell pattern. Signed-off-by: Jerin Jacob --- v3: - Address Thomas's comments http://patches.dpdk.org/patch/68225/ v2: - Fix typo devtools/check-includes.sh | 2 +- lib/librte_eal/common/eal_common_log.c | 4 ++-- lib/librte_eal/include/rte_log.h | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/devtools/check-includes.sh b/devtools/check-includes.sh index 3629ab4c7..749b9b26d 100755 --- a/devtools/check-includes.sh +++ b/devtools/check-includes.sh @@ -23,7 +23,7 @@ # PEDANTIC_CFLAGS, PEDANTIC_CXXFLAGS and PEDANTIC_CPPFLAGS provide strict # C/C++ compilation flags. # -# IGNORE contains a list of shell patterns matching files (relative to the +# IGNORE contains a list of globbing patterns matching files (relative to the # include directory) to avoid. It is set by default to known DPDK headers # which must not be included on their own. # diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c index d7a5f9b64..8835c8fff 100644 --- a/lib/librte_eal/common/eal_common_log.c +++ b/lib/librte_eal/common/eal_common_log.c @@ -29,7 +29,7 @@ struct rte_eal_opt_loglevel { TAILQ_ENTRY(rte_eal_opt_loglevel) next; /** Compiled regular expression obtained from the option */ regex_t re_match; - /** Glob match string option */ + /** Globbing pattern option */ char *pattern; /** Log level value obtained from the option */ uint32_t level; @@ -207,7 +207,7 @@ int rte_log_save_regexp(const char *regex, int tmp) return rte_log_save_level(tmp, regex, NULL); } -/* set log level based on glob (file match) pattern */ +/* set log level based on globbing pattern */ int rte_log_set_level_pattern(const char *pattern, uint32_t level) { diff --git a/lib/librte_eal/include/rte_log.h b/lib/librte_eal/include/rte_log.h index c020a3d7e..1789ede56 100644 --- a/lib/librte_eal/include/rte_log.h +++ b/lib/librte_eal/include/rte_log.h @@ -158,10 +158,10 @@ __rte_experimental bool rte_log_can_log(uint32_t logtype, uint32_t loglevel); /** - * Set the log level for a given type based on shell pattern. + * Set the log level for a given type based on globbing pattern. * * @param pattern - * The match pattern identifying the log type. + * The globbing pattern identifying the log type. * @param level * The level to be set. * @return -- 2.26.2