From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 236B1A0352;
Wed, 6 May 2020 05:10:25 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 3433D1D679;
Wed, 6 May 2020 05:10:24 +0200 (CEST)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 0C9D31D5DC;
Wed, 6 May 2020 05:10:21 +0200 (CEST)
IronPort-SDR: 5CXrY2p9BitLcKPxaPveb7tbwnfZFe8UV++GHyOrP0Qcju+N/ibcDb1zEvchxlUJdzPZk6M3n7
gbFPl759cFVA==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
05 May 2020 20:10:19 -0700
IronPort-SDR: sCdobNMXlb1g7/ugOXMy06yzHNTink3UGu4+HcAs7QVP09uyTZmRxpmDGmKOv3hMwTawGEiBGg
C9q5eOzwW7/Q==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.73,357,1583222400"; d="scan'208";a="278086333"
Received: from unknown (HELO intel.sh.intel.com) ([10.239.255.41])
by orsmga002.jf.intel.com with ESMTP; 05 May 2020 20:10:15 -0700
From: Junyu Jiang <junyux.jiang@intel.com>
To: dev@dpdk.org
Cc: Qiming Yang <qiming.yang@intel.com>, Junyu Jiang <junyux.jiang@intel.com>,
stable@dpdk.org
Date: Wed, 6 May 2020 03:05:25 +0000
Message-Id: <20200506030525.3907-1-junyux.jiang@intel.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20200429072516.65403-1-junyux.jiang@intel.com>
References: <20200429072516.65403-1-junyux.jiang@intel.com>
Subject: [dpdk-dev] [PATCH v2] net/ice: fix core dumped issue in switch
filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
The number of queues in queue group should be checked before
using it. This patch fixed the issue.
Fixes: 47d460d63233 ("net/ice: rework switch filter")
Cc: stable@dpdk.org
Signed-off-by: Junyu Jiang <junyux.jiang@intel.com>
Tested-by: Qimai Xiao <qimaix.xiao@intel.com>
---
drivers/net/ice/ice_switch_filter.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
index 179430136..c2762e331 100644
--- a/drivers/net/ice/ice_switch_filter.c
+++ b/drivers/net/ice/ice_switch_filter.c
@@ -1296,6 +1296,8 @@ ice_switch_parse_action(struct ice_pf *pf,
switch (action_type) {
case RTE_FLOW_ACTION_TYPE_RSS:
act_qgrop = action->conf;
+ if (act_qgrop->queue_num <= 1)
+ goto error;
rule_info->sw_act.fltr_act =
ICE_FWD_TO_QGRP;
rule_info->sw_act.fwd_id.q_id =
--
2.17.1