From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE950A0352; Wed, 6 May 2020 07:30:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E34221D67E; Wed, 6 May 2020 07:30:09 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6549D1D675 for ; Wed, 6 May 2020 07:30:08 +0200 (CEST) IronPort-SDR: uJQzv5zm7Y5D+1DpPIUBzO6sI4Dzs3B+YZTpatY3vlZuxxEGs2cyevMU6If7cO0YOopQKyqF3/ N+SmJvVTJ60Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2020 22:30:06 -0700 IronPort-SDR: v+ocVDOPScrJftaAF6O0iC2m5hG51n0PKXdOVdhhBFQLtw2POMYUhoxx8upQD/iWobT7NgmQp3 IqFBwBERAFoQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,358,1583222400"; d="scan'208";a="407111879" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by orsmga004.jf.intel.com with ESMTP; 05 May 2020 22:29:54 -0700 Date: Wed, 6 May 2020 13:22:12 +0800 From: Ye Xiaolong To: zhihongx.peng@intel.com Cc: wenzhuo.lu@intel.com, konstantin.ananyev@intel.com, dev@dpdk.org, liang-min.wang@intel.com Message-ID: <20200506052212.GC71070@intel.com> References: <20200417035212.16587-1-zhihongx.peng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200417035212.16587-1-zhihongx.peng@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix status synchronization on BSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/16, zhihongx.peng@intel.com wrote: >From: Peng Zhihong > >DPDK does not implement interrupt mechanism on BSD, >so force NIC status synchronization. > >Fixes: dc66e5fd01b9 (net/ixgbe: improve link state check on VF) >Cc: liang-min.wang@intel.com > >Signed-off-by: Peng Zhihong >--- > drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >index 2c5797635..efd8aced4 100644 >--- a/drivers/net/ixgbe/ixgbe_ethdev.c >+++ b/drivers/net/ixgbe/ixgbe_ethdev.c >@@ -4262,6 +4262,11 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, > if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0) > wait = 0; > >+/* BSD has no interrupt mechanism, so force NIC status synchronization. */ >+#ifdef RTE_EXEC_ENV_FREEBSD >+ wait = 1; >+#endif >+ > if (vf) > diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait); > else >-- >2.17.1 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel, Thanks.