* [dpdk-dev] [PATCH] crypto/kasumi: fix gcc 10 fno-common error
@ 2020-05-05 12:54 Kevin Traynor
2020-05-05 17:22 ` De Lara Guarch, Pablo
2020-05-06 9:45 ` [dpdk-dev] [PATCH v2] " Kevin Traynor
0 siblings, 2 replies; 5+ messages in thread
From: Kevin Traynor @ 2020-05-05 12:54 UTC (permalink / raw)
To: dev, pablo.de.lara.guarch; +Cc: david.marchand, Kevin Traynor
gcc 10 defaults to fno-common and it reports:
crypto_kasumi_rte_kasumi_pmd_ops.c.o:(.data.rel+0x0):
multiple definition of `rte_kasumi_pmd_ops';
crypto_kasumi_rte_kasumi_pmd.c.o:(.bss+0x8): first defined here
Fix by making rte_kasumi_pmd_ops extern in the header file.
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
drivers/crypto/kasumi/kasumi_pmd_private.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/kasumi/kasumi_pmd_private.h b/drivers/crypto/kasumi/kasumi_pmd_private.h
index b7f1c428b..abedcd616 100644
--- a/drivers/crypto/kasumi/kasumi_pmd_private.h
+++ b/drivers/crypto/kasumi/kasumi_pmd_private.h
@@ -77,5 +77,5 @@ kasumi_set_session_parameters(MB_MGR *mgr, struct kasumi_session *sess,
/** device specific operations function pointer structure */
-struct rte_cryptodev_ops *rte_kasumi_pmd_ops;
+extern struct rte_cryptodev_ops *rte_kasumi_pmd_ops;
#endif /* _KASUMI_PMD_PRIVATE_H_ */
--
2.21.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/kasumi: fix gcc 10 fno-common error
2020-05-05 12:54 [dpdk-dev] [PATCH] crypto/kasumi: fix gcc 10 fno-common error Kevin Traynor
@ 2020-05-05 17:22 ` De Lara Guarch, Pablo
2020-05-06 9:45 ` Kevin Traynor
2020-05-06 9:45 ` [dpdk-dev] [PATCH v2] " Kevin Traynor
1 sibling, 1 reply; 5+ messages in thread
From: De Lara Guarch, Pablo @ 2020-05-05 17:22 UTC (permalink / raw)
To: Kevin Traynor, dev; +Cc: david.marchand
Hi Kevin,
> -----Original Message-----
> From: Kevin Traynor <ktraynor@redhat.com>
> Sent: Tuesday, May 5, 2020 1:55 PM
> To: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: david.marchand@redhat.com; Kevin Traynor <ktraynor@redhat.com>
> Subject: [PATCH] crypto/kasumi: fix gcc 10 fno-common error
>
> gcc 10 defaults to fno-common and it reports:
>
> crypto_kasumi_rte_kasumi_pmd_ops.c.o:(.data.rel+0x0):
> multiple definition of `rte_kasumi_pmd_ops';
> crypto_kasumi_rte_kasumi_pmd.c.o:(.bss+0x8): first defined here
>
> Fix by making rte_kasumi_pmd_ops extern in the header file.
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
Patch looks good, but you are missing fixes line and CC stable, right?
Apart from that:
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/kasumi: fix gcc 10 fno-common error
2020-05-05 17:22 ` De Lara Guarch, Pablo
@ 2020-05-06 9:45 ` Kevin Traynor
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Traynor @ 2020-05-06 9:45 UTC (permalink / raw)
To: De Lara Guarch, Pablo, dev; +Cc: david.marchand
On 05/05/2020 18:22, De Lara Guarch, Pablo wrote:
> Hi Kevin,
>
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Tuesday, May 5, 2020 1:55 PM
>> To: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>> Cc: david.marchand@redhat.com; Kevin Traynor <ktraynor@redhat.com>
>> Subject: [PATCH] crypto/kasumi: fix gcc 10 fno-common error
>>
>> gcc 10 defaults to fno-common and it reports:
>>
>> crypto_kasumi_rte_kasumi_pmd_ops.c.o:(.data.rel+0x0):
>> multiple definition of `rte_kasumi_pmd_ops';
>> crypto_kasumi_rte_kasumi_pmd.c.o:(.bss+0x8): first defined here
>>
>> Fix by making rte_kasumi_pmd_ops extern in the header file.
>>
>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>
> Patch looks good, but you are missing fixes line and CC stable, right?
> Apart from that:
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
Thanks Pablo, sent v2 with the tags and your ack.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] crypto/kasumi: fix gcc 10 fno-common error
2020-05-05 12:54 [dpdk-dev] [PATCH] crypto/kasumi: fix gcc 10 fno-common error Kevin Traynor
2020-05-05 17:22 ` De Lara Guarch, Pablo
@ 2020-05-06 9:45 ` Kevin Traynor
2020-05-09 22:01 ` Akhil Goyal
1 sibling, 1 reply; 5+ messages in thread
From: Kevin Traynor @ 2020-05-06 9:45 UTC (permalink / raw)
To: dev, pablo.de.lara.guarch; +Cc: david.marchand, Kevin Traynor, stable
gcc 10 defaults to fno-common and it reports:
crypto_kasumi_rte_kasumi_pmd_ops.c.o:(.data.rel+0x0):
multiple definition of `rte_kasumi_pmd_ops';
crypto_kasumi_rte_kasumi_pmd.c.o:(.bss+0x8): first defined here
Fix by making rte_kasumi_pmd_ops extern in the header file.
Fixes: 2773c86d061a ("crypto/kasumi: add driver for KASUMI library")
Cc: stable@dpdk.org
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
v2: add tags and ack
---
drivers/crypto/kasumi/kasumi_pmd_private.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/kasumi/kasumi_pmd_private.h b/drivers/crypto/kasumi/kasumi_pmd_private.h
index b7f1c428b..abedcd616 100644
--- a/drivers/crypto/kasumi/kasumi_pmd_private.h
+++ b/drivers/crypto/kasumi/kasumi_pmd_private.h
@@ -77,5 +77,5 @@ kasumi_set_session_parameters(MB_MGR *mgr, struct kasumi_session *sess,
/** device specific operations function pointer structure */
-struct rte_cryptodev_ops *rte_kasumi_pmd_ops;
+extern struct rte_cryptodev_ops *rte_kasumi_pmd_ops;
#endif /* _KASUMI_PMD_PRIVATE_H_ */
--
2.21.3
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] crypto/kasumi: fix gcc 10 fno-common error
2020-05-06 9:45 ` [dpdk-dev] [PATCH v2] " Kevin Traynor
@ 2020-05-09 22:01 ` Akhil Goyal
0 siblings, 0 replies; 5+ messages in thread
From: Akhil Goyal @ 2020-05-09 22:01 UTC (permalink / raw)
To: Kevin Traynor, dev, pablo.de.lara.guarch; +Cc: david.marchand, stable
> gcc 10 defaults to fno-common and it reports:
>
> crypto_kasumi_rte_kasumi_pmd_ops.c.o:(.data.rel+0x0):
> multiple definition of `rte_kasumi_pmd_ops';
> crypto_kasumi_rte_kasumi_pmd.c.o:(.bss+0x8): first defined here
>
> Fix by making rte_kasumi_pmd_ops extern in the header file.
>
> Fixes: 2773c86d061a ("crypto/kasumi: add driver for KASUMI library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-09 22:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-05 12:54 [dpdk-dev] [PATCH] crypto/kasumi: fix gcc 10 fno-common error Kevin Traynor
2020-05-05 17:22 ` De Lara Guarch, Pablo
2020-05-06 9:45 ` Kevin Traynor
2020-05-06 9:45 ` [dpdk-dev] [PATCH v2] " Kevin Traynor
2020-05-09 22:01 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).