DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Gaëtan Rivet" <grive@u256.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org,
	Marko Kovacevic <marko.kovacevic@intel.com>,
	Ori Kam <orika@mellanox.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Radu Nicolau <radu.nicolau@intel.com>,
	Akhil Goyal <akhil.goyal@nxp.com>,
	Tomasz Kantecki <tomasz.kantecki@intel.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	Pavan Nikhilesh <pbhagavatula@marvell.com>,
	John McNamara <john.mcnamara@intel.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Zhihong Wang <zhihong.wang@intel.com>,
	Xiaolong Ye <xiaolong.ye@intel.com>,
	Gaetan Rivet <gaetan.rivet@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] remove references to private PCI probe function
Date: Wed, 6 May 2020 16:05:57 +0200	[thread overview]
Message-ID: <20200506140557.sm4hsakfe3cam22m@u256.net> (raw)
In-Reply-To: <20200506124314.14009-1-david.marchand@redhat.com>

Hello David,

On 06/05/20 14:43 +0200, David Marchand wrote:
> rte_pci_probe() is private to the PCI bus.
> Clean the remaining references in the documentation and comments.
> 
> Fixes: c752998b5e2e ("pci: introduce library and driver")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  doc/guides/sample_app_ug/l2_forward_event.rst        |  8 --------
>  doc/guides/sample_app_ug/l2_forward_real_virtual.rst |  9 ---------
>  doc/guides/sample_app_ug/link_status_intr.rst        |  7 -------
>  doc/guides/sample_app_ug/multi_process.rst           |  2 +-
>  drivers/bus/pci/pci_common.c                         |  6 +++---
>  drivers/bus/pci/private.h                            | 10 ----------
>  drivers/net/virtio/virtio_user_ethdev.c              |  2 +-
>  7 files changed, 5 insertions(+), 39 deletions(-)
> 
> diff --git a/doc/guides/sample_app_ug/l2_forward_event.rst b/doc/guides/sample_app_ug/l2_forward_event.rst
> index 8bdf352c4e..d536eee819 100644
> --- a/doc/guides/sample_app_ug/l2_forward_event.rst
> +++ b/doc/guides/sample_app_ug/l2_forward_event.rst
> @@ -204,9 +204,6 @@ chapters that related to the Poll Mode and Event mode Driver in the
>  
>  .. code-block:: c
>  
> -    if (rte_pci_probe() < 0)
> -        rte_panic("Cannot probe PCI\n");
> -
>      /* reset l2fwd_dst_ports */
>  
>      for (portid = 0; portid < RTE_MAX_ETHPORTS; portid++)
> @@ -236,11 +233,6 @@ chapters that related to the Poll Mode and Event mode Driver in the
>          rte_eth_dev_info_get((uint8_t) portid, &dev_info);
>      }
>  
> -Observe that:
> -
> -*   rte_pci_probe() parses the devices on the PCI bus and initializes recognized
> -    devices.
> -

Reading the docs overall, what needed to be covered by referencing
rte_pci_probe() here should be covered by the reference to
rte_eal_init() earlier.

So simply removing rte_pci_probe() line in these docs seems ok.

LGTM,

Reviewed-by: Gaetan Rivet <grive@u256.net>


-- 
Gaëtan

  parent reply	other threads:[~2020-05-06 14:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 12:43 David Marchand
2020-05-06 12:43 ` [dpdk-dev] [PATCH 2/2] bus/pci: cleanup private symbols David Marchand
2020-05-06 17:21   ` Gaëtan Rivet
2020-05-06 20:25     ` Stephen Hemminger
2020-05-07 12:43       ` David Marchand
2020-05-07 12:41     ` David Marchand
2020-05-06 14:05 ` Gaëtan Rivet [this message]
2020-05-11 14:56 ` [dpdk-dev] [PATCH 1/2] remove references to private PCI probe function David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200506140557.sm4hsakfe3cam22m@u256.net \
    --to=grive@u256.net \
    --cc=akhil.goyal@nxp.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=orika@mellanox.com \
    --cc=pbhagavatula@marvell.com \
    --cc=radu.nicolau@intel.com \
    --cc=skori@marvell.com \
    --cc=stable@dpdk.org \
    --cc=tomasz.kantecki@intel.com \
    --cc=xiaolong.ye@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).