From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 019D4A034E;
Wed, 6 May 2020 21:28:13 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 18CD41DA0E;
Wed, 6 May 2020 21:27:55 +0200 (CEST)
Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com
[209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 714111DA09
for <dev@dpdk.org>; Wed, 6 May 2020 21:27:51 +0200 (CEST)
Received: by mail-pf1-f195.google.com with SMTP id x77so1545779pfc.0
for <dev@dpdk.org>; Wed, 06 May 2020 12:27:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=7zlbwXrKQWiCDsdzyzRp5gH2z/2CUQk+AgTY9p9fgHg=;
b=VDYSVGMycpB1fBX55CMdOiq7sH6WgkwiaBIALIAIEYG/C9V1ayNn+Vt8MZNKZ9Fcsc
MB5IDD+vlg+NW+Xg4Qhhs50jbE6m+i+imARm0cGNp2Iema8ldhFnIcYslsXNNWUB44e8
OYkxgkIxF/ZBZeHNn3MjqX7CYMVkVJbrAo/1HLSH7Bob5rLVJ/MZA2WCWwJE09on9npq
6COpF6QhTS1lODybgxqR5cqW1EFAif5uFqVB7TrjwVwUSstXTESZ1V0E8lQKqOciV58B
8UV0ThOak7AvJwpLu4uhOKf5XFHbvDd1qOS2/Op1HUXwdVwyR4D69aIvw/J444wgz7IT
a5Jw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=7zlbwXrKQWiCDsdzyzRp5gH2z/2CUQk+AgTY9p9fgHg=;
b=H3ARRUNCZP3CxMSLleQ79OGm1yJqtOUke43//l2vqLrTKZDJKtwH+ClDhgLfiEoW9j
Q9YRzEd7YWlAyDvtpixhS8H88MQJH5Ephio4m5cTClntycFC3PhSb3NGNtL16M0A462T
1IHNkiQJblW1fG1WfPVCW6nQtVykWjsOoW75tYkygJmWB0gNL6edXoAe9V9UT9/bixg4
pZ/RkoxxHUt5JPl9OcCjEK0MQOBLDnI6VGaWSkNl/aPcyV4BVKWYkxogCIgTNSiCdBdb
qzYTKndf9Bt+GeLwFit673raPgtcQVj71gcHnTXM8HgdqxmpoA1gO/FCt4lCMiU1R/Vo
3qpg==
X-Gm-Message-State: AGi0PuaY8jjflV4PL8ckVzw8rv41FZDqCw0w5RdO9/6r8LSqPDCi+2OD
EgQxhdsETHD7Kn622KAlprOBGrUMHO9WrQ==
X-Google-Smtp-Source: APiQypIHatBBZF9LfQkQc2drB4YJUZaFDGKJot7jCMgeCI7A9ELtBzaRzn7TFEK25Rp6gxEBTnA53Q==
X-Received: by 2002:a63:34ce:: with SMTP id b197mr8310568pga.436.1588793269974;
Wed, 06 May 2020 12:27:49 -0700 (PDT)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
by smtp.gmail.com with ESMTPSA id i15sm2105511pgj.30.2020.05.06.12.27.48
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 06 May 2020 12:27:48 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 6 May 2020 12:27:29 -0700
Message-Id: <20200506192730.21613-4-stephen@networkplumber.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20200506192730.21613-1-stephen@networkplumber.org>
References: <20200506192730.21613-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH 3/4] net/netvsc: change tx/rx error handling
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
The PMD_TX_LOG and PMD_RX_LOG can hide errors since the
debug log is typically disabled. Change the code to use
PMD_DRV_LOG for errors.
Under load, the ring buffer to the host can fill.
Add some statistics to estimate the impact and see other errors.
---
drivers/net/netvsc/hn_ethdev.c | 1 +
drivers/net/netvsc/hn_rxtx.c | 29 ++++++++++++++++++++---------
drivers/net/netvsc/hn_var.h | 1 +
3 files changed, 22 insertions(+), 9 deletions(-)
diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 675a49e66a57..0f4827c54be4 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -58,6 +58,7 @@ static const struct hn_xstats_name_off hn_stat_strings[] = {
{ "good_bytes", offsetof(struct hn_stats, bytes) },
{ "errors", offsetof(struct hn_stats, errors) },
{ "ring full", offsetof(struct hn_stats, ring_full) },
+ { "channel full", offsetof(struct hn_stats, channel_full) },
{ "multicast_packets", offsetof(struct hn_stats, multicast) },
{ "broadcast_packets", offsetof(struct hn_stats, broadcast) },
{ "undersize_packets", offsetof(struct hn_stats, size_bins[0]) },
diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
index 537fd0125687..fa53c7becc12 100644
--- a/drivers/net/netvsc/hn_rxtx.c
+++ b/drivers/net/netvsc/hn_rxtx.c
@@ -403,8 +403,8 @@ hn_nvs_send_completed(struct rte_eth_dev *dev, uint16_t queue_id,
txq->stats.bytes += txd->data_size;
txq->stats.packets += txd->packets;
} else {
- PMD_TX_LOG(NOTICE, "port %u:%u complete tx %u failed status %u",
- txq->port_id, txq->queue_id, txd->chim_index, ack->status);
+ PMD_DRV_LOG(NOTICE, "port %u:%u complete tx %u failed status %u",
+ txq->port_id, txq->queue_id, txd->chim_index, ack->status);
++txq->stats.errors;
}
@@ -429,8 +429,7 @@ hn_nvs_handle_comp(struct rte_eth_dev *dev, uint16_t queue_id,
break;
default:
- PMD_TX_LOG(NOTICE,
- "unexpected send completion type %u",
+ PMD_DRV_LOG(NOTICE, "unexpected send completion type %u",
hdr->type);
}
}
@@ -648,6 +647,7 @@ static void hn_rxpkt(struct hn_rx_queue *rxq, struct hn_rx_bufinfo *rxb,
if (unlikely(rte_ring_sp_enqueue(rxq->rx_ring, m) != 0)) {
++rxq->stats.ring_full;
+ PMD_RX_LOG(DEBUG, "rx ring full");
rte_pktmbuf_free(m);
}
}
@@ -1156,10 +1156,16 @@ static int hn_flush_txagg(struct hn_tx_queue *txq, bool *need_sig)
if (likely(ret == 0))
hn_reset_txagg(txq);
- else
- PMD_TX_LOG(NOTICE, "port %u:%u send failed: %d",
- txq->port_id, txq->queue_id, ret);
+ else if (ret == -EAGAIN) {
+ PMD_TX_LOG(DEBUG, "port %u:%u channel full",
+ txq->port_id, txq->queue_id);
+ ++txq->stats.channel_full;
+ } else {
+ ++txq->stats.errors;
+ PMD_DRV_LOG(NOTICE, "port %u:%u send failed: %d",
+ txq->port_id, txq->queue_id, ret);
+ }
return ret;
}
@@ -1505,8 +1511,13 @@ hn_xmit_pkts(void *ptxq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
ret = hn_xmit_sg(txq, txd, m, &need_sig);
if (unlikely(ret != 0)) {
- PMD_TX_LOG(NOTICE, "sg send failed: %d", ret);
- ++txq->stats.errors;
+ if (ret == -EAGAIN) {
+ PMD_TX_LOG(DEBUG, "sg channel full");
+ ++txq->stats.channel_full;
+ } else {
+ PMD_DRV_LOG(NOTICE, "sg send failed: %d", ret);
+ ++txq->stats.errors;
+ }
hn_txd_put(txq, txd);
goto fail;
}
diff --git a/drivers/net/netvsc/hn_var.h b/drivers/net/netvsc/hn_var.h
index ded0d4c60a04..20363389a0d6 100644
--- a/drivers/net/netvsc/hn_var.h
+++ b/drivers/net/netvsc/hn_var.h
@@ -40,6 +40,7 @@ struct hn_stats {
uint64_t bytes;
uint64_t errors;
uint64_t ring_full;
+ uint64_t channel_full;
uint64_t multicast;
uint64_t broadcast;
/* Size bins in array as RFC 2819, undersized [0], 64 [1], etc */
--
2.20.1