DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] event/dsw: fix enqueue burst return value
@ 2020-05-06 11:09 lironh
  2020-05-06 11:19 ` Mattias Rönnblom
  2020-05-06 20:18 ` [dpdk-dev] [PATCH v2] " lironh
  0 siblings, 2 replies; 5+ messages in thread
From: lironh @ 2020-05-06 11:09 UTC (permalink / raw)
  To: mattias.ronnblom, jerinj; +Cc: dev, stable, Yuri Chipchev, Liron Himi

From: Yuri Chipchev <yuric@marvell.com>

number of enqueued events doesn't include events
that were marked with RTE_EVENT_OP_RELEASE

Fixes: 1c8e3caa3 ("event/dsw: add event scheduling and device start/stop")
Cc: stable@dpdk.org

Signed-off-by: Yuri Chipchev <yuric@marvell.com>
Reviewed-by: Liron Himi <lironh@marvell.com>
---
 drivers/event/dsw/dsw_event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
index e5e3597aa..611b36781 100644
--- a/drivers/event/dsw/dsw_event.c
+++ b/drivers/event/dsw/dsw_event.c
@@ -1231,7 +1231,7 @@ dsw_event_enqueue_burst_generic(struct dsw_port *source_port,
 	DSW_LOG_DP_PORT(DEBUG, source_port->id, "%d non-release events "
 			"accepted.\n", num_non_release);
 
-	return num_non_release;
+	return (num_non_release + num_release);
 }
 
 uint16_t
-- 
2.23.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] event/dsw: fix enqueue burst return value
  2020-05-06 11:09 [dpdk-dev] [PATCH] event/dsw: fix enqueue burst return value lironh
@ 2020-05-06 11:19 ` Mattias Rönnblom
  2020-05-06 20:18 ` [dpdk-dev] [PATCH v2] " lironh
  1 sibling, 0 replies; 5+ messages in thread
From: Mattias Rönnblom @ 2020-05-06 11:19 UTC (permalink / raw)
  To: lironh, jerinj; +Cc: dev, stable, Yuri Chipchev

On 2020-05-06 13:09, lironh@marvell.com wrote:
> From: Yuri Chipchev <yuric@marvell.com>
>
> number of enqueued events doesn't include events
> that were marked with RTE_EVENT_OP_RELEASE


You should have a complete sentence. "The returned number from 
rte_event_enqueue_*() wouldn't include events marked with 
RTE_EVENT_OP_RELEASE.", or something like that.


Other than that:

Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>


> Fixes: 1c8e3caa3 ("event/dsw: add event scheduling and device start/stop")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuri Chipchev <yuric@marvell.com>
> Reviewed-by: Liron Himi <lironh@marvell.com>
> ---
>   drivers/event/dsw/dsw_event.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
> index e5e3597aa..611b36781 100644
> --- a/drivers/event/dsw/dsw_event.c
> +++ b/drivers/event/dsw/dsw_event.c
> @@ -1231,7 +1231,7 @@ dsw_event_enqueue_burst_generic(struct dsw_port *source_port,
>   	DSW_LOG_DP_PORT(DEBUG, source_port->id, "%d non-release events "
>   			"accepted.\n", num_non_release);
>   
> -	return num_non_release;
> +	return (num_non_release + num_release);
>   }
>   
>   uint16_t



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] [PATCH v2] event/dsw: fix enqueue burst return value
  2020-05-06 11:09 [dpdk-dev] [PATCH] event/dsw: fix enqueue burst return value lironh
  2020-05-06 11:19 ` Mattias Rönnblom
@ 2020-05-06 20:18 ` lironh
  2020-05-07  6:09   ` Mattias Rönnblom
  1 sibling, 1 reply; 5+ messages in thread
From: lironh @ 2020-05-06 20:18 UTC (permalink / raw)
  To: mattias.ronnblom, jerinj; +Cc: dev, stable, Yuri Chipchev, Liron Himi

From: Yuri Chipchev <yuric@marvell.com>

The returned number from rte_event_enqueue_*()
wouldn't include events marked with RTE_EVENT_OP_RELEASE.

Fixes: 1c8e3caa3 ("event/dsw: add event scheduling and device start/stop")
Cc: stable@dpdk.org

Signed-off-by: Yuri Chipchev <yuric@marvell.com>
Reviewed-by: Liron Himi <lironh@marvell.com>
---
v2:
- update commit description

 drivers/event/dsw/dsw_event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
index e5e3597aa..611b36781 100644
--- a/drivers/event/dsw/dsw_event.c
+++ b/drivers/event/dsw/dsw_event.c
@@ -1231,7 +1231,7 @@ dsw_event_enqueue_burst_generic(struct dsw_port *source_port,
 	DSW_LOG_DP_PORT(DEBUG, source_port->id, "%d non-release events "
 			"accepted.\n", num_non_release);
 
-	return num_non_release;
+	return (num_non_release + num_release);
 }
 
 uint16_t
-- 
2.23.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v2] event/dsw: fix enqueue burst return value
  2020-05-06 20:18 ` [dpdk-dev] [PATCH v2] " lironh
@ 2020-05-07  6:09   ` Mattias Rönnblom
  2020-05-14  7:15     ` Jerin Jacob
  0 siblings, 1 reply; 5+ messages in thread
From: Mattias Rönnblom @ 2020-05-07  6:09 UTC (permalink / raw)
  To: lironh, jerinj; +Cc: dev, stable, Yuri Chipchev

On 2020-05-06 22:18, lironh@marvell.com wrote:
> From: Yuri Chipchev <yuric@marvell.com>
>
> The returned number from rte_event_enqueue_*()
> wouldn't include events marked with RTE_EVENT_OP_RELEASE.
>
> Fixes: 1c8e3caa3 ("event/dsw: add event scheduling and device start/stop")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yuri Chipchev <yuric@marvell.com>
> Reviewed-by: Liron Himi <lironh@marvell.com>


Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>


> ---
> v2:
> - update commit description
>
>   drivers/event/dsw/dsw_event.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
> index e5e3597aa..611b36781 100644
> --- a/drivers/event/dsw/dsw_event.c
> +++ b/drivers/event/dsw/dsw_event.c
> @@ -1231,7 +1231,7 @@ dsw_event_enqueue_burst_generic(struct dsw_port *source_port,
>   	DSW_LOG_DP_PORT(DEBUG, source_port->id, "%d non-release events "
>   			"accepted.\n", num_non_release);
>   
> -	return num_non_release;
> +	return (num_non_release + num_release);
>   }
>   
>   uint16_t



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v2] event/dsw: fix enqueue burst return value
  2020-05-07  6:09   ` Mattias Rönnblom
@ 2020-05-14  7:15     ` Jerin Jacob
  0 siblings, 0 replies; 5+ messages in thread
From: Jerin Jacob @ 2020-05-14  7:15 UTC (permalink / raw)
  To: Mattias Rönnblom; +Cc: lironh, jerinj, dev, stable, Yuri Chipchev

On Thu, May 7, 2020 at 11:39 AM Mattias Rönnblom
<mattias.ronnblom@ericsson.com> wrote:
>
> On 2020-05-06 22:18, lironh@marvell.com wrote:
> > From: Yuri Chipchev <yuric@marvell.com>
> >
> > The returned number from rte_event_enqueue_*()
> > wouldn't include events marked with RTE_EVENT_OP_RELEASE.
> >
> > Fixes: 1c8e3caa3 ("event/dsw: add event scheduling and device start/stop")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Yuri Chipchev <yuric@marvell.com>
> > Reviewed-by: Liron Himi <lironh@marvell.com>
>
>
> Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>

Applied to dpdk-next-eventdev/master. Thanks.



>
>
> > ---
> > v2:
> > - update commit description
> >
> >   drivers/event/dsw/dsw_event.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c
> > index e5e3597aa..611b36781 100644
> > --- a/drivers/event/dsw/dsw_event.c
> > +++ b/drivers/event/dsw/dsw_event.c
> > @@ -1231,7 +1231,7 @@ dsw_event_enqueue_burst_generic(struct dsw_port *source_port,
> >       DSW_LOG_DP_PORT(DEBUG, source_port->id, "%d non-release events "
> >                       "accepted.\n", num_non_release);
> >
> > -     return num_non_release;
> > +     return (num_non_release + num_release);
> >   }
> >
> >   uint16_t
>
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-05-14  7:15 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 11:09 [dpdk-dev] [PATCH] event/dsw: fix enqueue burst return value lironh
2020-05-06 11:19 ` Mattias Rönnblom
2020-05-06 20:18 ` [dpdk-dev] [PATCH v2] " lironh
2020-05-07  6:09   ` Mattias Rönnblom
2020-05-14  7:15     ` Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).