DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@mellanox.com>
To: ferruh.yigit@intel.com
Cc: dev@dpdk.org, stephen@networkplumber.org
Subject: [dpdk-dev] [PATCH] net/tap: fix compilation issue glibc < 2.24
Date: Sun, 10 May 2020 15:23:47 +0300	[thread overview]
Message-ID: <20200510122347.2742-1-rasland@mellanox.com> (raw)

When trying to compile with glibc < 2.24 that doesn't
support SOL_NETLINK it will cause compilation failure:

drivers/net/tap/tap_netlink.c:70:17: error:
 'SOL_NETLINK' undeclared (first use in this function)
  setsockopt(fd, SOL_NETLINK, NETLINK_EXT_ACK, &one, sizeof(one));

Fixes: b9cf1a882820 ("net/tap: use netlink extended ack support")
Cc: stephen@networkplumber.org

Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
---
 drivers/net/tap/tap_netlink.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/tap/tap_netlink.c b/drivers/net/tap/tap_netlink.c
index b73802b51..dcd7ab99b 100644
--- a/drivers/net/tap/tap_netlink.c
+++ b/drivers/net/tap/tap_netlink.c
@@ -17,6 +17,11 @@
 
 #include "tap_log.h"
 
+/*define SOL_NETLINK for old kernels usage. */
+#ifndef SOL_NETLINK
+#define SOL_NETLINK     270
+#endif
+
 /* Must be quite large to support dumping a huge list of QDISC or filters. */
 #define BUF_SIZE (32 * 1024) /* Size of the buffer to receive kernel messages */
 #define SNDBUF_SIZE 32768 /* Send buffer size for the netlink socket */
-- 
2.26.0


             reply	other threads:[~2020-05-10 12:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-10 12:23 Raslan Darawsheh [this message]
2020-05-11 16:13 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200510122347.2742-1-rasland@mellanox.com \
    --to=rasland@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).