From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACD82A0350; Mon, 11 May 2020 11:04:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D1981C2AA; Mon, 11 May 2020 11:04:58 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 885B41C243 for ; Mon, 11 May 2020 11:04:56 +0200 (CEST) IronPort-SDR: zwa+MNQ+njMqDGks9O3W1vfk5ivYcl+rQUEnROgMYIgDkBXLI1kFpoV8F4akZJiM0tpBAlG+0X rwrdrBE9BQow== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 02:04:55 -0700 IronPort-SDR: jhEhXHQV+JZw6863kwUcR4X9bym89vQyn6JUSfxHNoQE5sP4inT98laVsNo+7mNZVqDZupoyud ffhBzv3o4kQg== X-IronPort-AV: E=Sophos;i="5.73,379,1583222400"; d="scan'208";a="408859857" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.48]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 May 2020 02:04:53 -0700 Date: Mon, 11 May 2020 10:04:38 +0100 From: Bruce Richardson To: "Burakov, Anatoly" Cc: Stephen Hemminger , dev@dpdk.org, pbhagavatula@caviumnetworks.com Message-ID: <20200511090438.GB1957@bricha3-MOBL.ger.corp.intel.com> References: <20200508232505.2275-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] eal: remove register from function parameter in headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 11, 2020 at 09:56:10AM +0100, Burakov, Anatoly wrote: > On 09-May-20 12:25 AM, Stephen Hemminger wrote: > > Compiling a C++ application that includes directly or indirectly > > rte_common.h will cause a warning: > > > > include/rte_common.h:350:37: warning: ISO C++17 does not allow ‘register’ storage class specifier [-Wregister] > > rte_combine32ms1b(register uint32_t x) > > > > C++ pickier than standard C and flags this antique usage. > > > > This is a bugfix please apply to 20.05. > > The register keyword is an old K&R legacy and should be removed > > everywhere in DPDK. For now, fix it where it hurts. > > Checkpatch should also be able to flag use of register keyword. > > > > Fixes: 08f683174e94 ("eal: add functions for previous power of 2 alignment") > > Cc: pbhagavatula@caviumnetworks.com > > Signed-off-by: Stephen Hemminger > > --- > > I remember similar patches already being submitted, and the community has > decided that 'register' keyword was worth keeping (although i don't recall > the reasoning). Has something changed since then? > I'm not sure anything has changed - and I don't see the need for register keyword myself - but all headers must be includable in C++ code. Therefore we need to remove register from rte_common.h Acked-by: Bruce Richardson