DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] meson: error out on failed kernel module builds
Date: Mon, 11 May 2020 11:27:39 +0100	[thread overview]
Message-ID: <20200511102739.GC1957@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <e62eef353153ba9469daafabe6c0e068df02d100.1589192706.git.anatoly.burakov@intel.com>

On Mon, May 11, 2020 at 11:25:13AM +0100, Anatoly Burakov wrote:
> Now that kernel modules aren't built by default, we can be more
> strict with their build process, and fail the build if they were
> requested to be built, but weren't.
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
I think erroring out is the right thing to do, now that modules need to be
explicitly enabled.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

  reply	other threads:[~2020-05-11 10:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-11 10:25 Anatoly Burakov
2020-05-11 10:27 ` Bruce Richardson [this message]
2020-05-19 16:01   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200511102739.GC1957@bricha3-MOBL.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).