From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BA5AA0350; Mon, 11 May 2020 12:27:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D0191C202; Mon, 11 May 2020 12:27:46 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4F69B1C138 for ; Mon, 11 May 2020 12:27:44 +0200 (CEST) IronPort-SDR: Sgtwy9GjfLxvsJSPVrwIEuLknGDTzAswFyIGDWarm6k0slmoLFhgJJEbj+3cz66RhOlfrqtPk8 VUoOMemMOnaw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 03:27:43 -0700 IronPort-SDR: nOGmPUGJsC6X4lgByz2Nw+UJwWDYK55/nA5kRHnyUC8Bt3JsUlscwPfqt6ljtAK5NmIbJfWh3T kq4JpzFZwXHw== X-IronPort-AV: E=Sophos;i="5.73,379,1583222400"; d="scan'208";a="436649450" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.48]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 May 2020 03:27:42 -0700 Date: Mon, 11 May 2020 11:27:39 +0100 From: Bruce Richardson To: Anatoly Burakov Cc: dev@dpdk.org Message-ID: <20200511102739.GC1957@bricha3-MOBL.ger.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] meson: error out on failed kernel module builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 11, 2020 at 11:25:13AM +0100, Anatoly Burakov wrote: > Now that kernel modules aren't built by default, we can be more > strict with their build process, and fail the build if they were > requested to be built, but weren't. > > Signed-off-by: Anatoly Burakov > --- I think erroring out is the right thing to do, now that modules need to be explicitly enabled. Acked-by: Bruce Richardson