From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Kevin Laatz <kevin.laatz@intel.com>,
Ciara Power <ciara.power@intel.com>,
Keith Wiles <keith.wiles@intel.com>
Subject: Re: [dpdk-dev] [PATCH] telemetry: fix build for armv7
Date: Mon, 11 May 2020 15:23:12 +0100 [thread overview]
Message-ID: <20200511142312.GE1957@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <CAJFAV8x=3M4vq08EE=--fGs76=CwjF8uiHJvedQZgEcgbdkZVQ@mail.gmail.com>
On Mon, May 11, 2020 at 03:58:47PM +0200, David Marchand wrote:
> On Mon, May 11, 2020 at 3:47 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > On Mon, May 11, 2020 at 03:32:12PM +0200, David Marchand wrote:
> > > telemetry can not depend on EAL anymore but it still wants to get arch
> > > headers.
> > > We directly point at the right source directories by using the same logic
> > > than EAL. However the special case of armv7 has been missed.
> > >
> > No objection to the fix, but why is ARMv7 needing special treatment?
>
> For ARMv7, RTE_ARCH == ARCH_DIR so it is not set in mk/arch/* but a
> default value is still set in EAL makefiles.
> We could hide this in rte.vars.mk so that other components' makefiles
> do not have to care about it but I went with the quicker fix.
>
Thanks for the explanation.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2020-05-11 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 13:32 David Marchand
2020-05-11 13:47 ` Bruce Richardson
2020-05-11 13:58 ` David Marchand
2020-05-11 14:23 ` Bruce Richardson [this message]
2020-05-11 15:21 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511142312.GE1957@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).