From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFF8AA0350; Mon, 11 May 2020 16:23:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E5E12B96; Mon, 11 May 2020 16:23:19 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2199E255 for ; Mon, 11 May 2020 16:23:17 +0200 (CEST) IronPort-SDR: sE2VbWhzA1M1KaQuPnwYS0PjXCTXrHiUl7WBl9LSu42EcQyD6rLLkjprwyV3jvf/r3gR61CLGN 7WgDxTyfbfZw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2020 07:23:16 -0700 IronPort-SDR: 7Bva3imYoR2mbnbPd8stgJM9KbbA4EXaMtkcwALylbF3y/fvM0e4EqvslPk5bFDxUgDOGckxG9 ZOX7Qqbx/W3A== X-IronPort-AV: E=Sophos;i="5.73,380,1583222400"; d="scan'208";a="408930990" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.17.48]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 May 2020 07:23:15 -0700 Date: Mon, 11 May 2020 15:23:12 +0100 From: Bruce Richardson To: David Marchand Cc: dev , Kevin Laatz , Ciara Power , Keith Wiles Message-ID: <20200511142312.GE1957@bricha3-MOBL.ger.corp.intel.com> References: <20200511133212.21444-1-david.marchand@redhat.com> <20200511134734.GD1957@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH] telemetry: fix build for armv7 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, May 11, 2020 at 03:58:47PM +0200, David Marchand wrote: > On Mon, May 11, 2020 at 3:47 PM Bruce Richardson > wrote: > > > > On Mon, May 11, 2020 at 03:32:12PM +0200, David Marchand wrote: > > > telemetry can not depend on EAL anymore but it still wants to get arch > > > headers. > > > We directly point at the right source directories by using the same logic > > > than EAL. However the special case of armv7 has been missed. > > > > > No objection to the fix, but why is ARMv7 needing special treatment? > > For ARMv7, RTE_ARCH == ARCH_DIR so it is not set in mk/arch/* but a > default value is still set in EAL makefiles. > We could hide this in rte.vars.mk so that other components' makefiles > do not have to care about it but I went with the quicker fix. > Thanks for the explanation. Acked-by: Bruce Richardson