From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3483AA034F; Wed, 13 May 2020 04:14:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 61CF01BFA1; Wed, 13 May 2020 04:14:38 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 891531BF9E; Wed, 13 May 2020 04:14:36 +0200 (CEST) IronPort-SDR: 6kqCOC3asyMM/QY7dlozIoHnORSqdlBUXFIRoZp5VJ+aeoe0llXm2it4+5h//Jz+tdlQrwOqto xPmrXAEWJObw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 19:14:35 -0700 IronPort-SDR: loGik9MutGiKBmiuqdLh1yj8JJ71WQNJawQwt8LMLV7LABZBzyYBud/aRBT/eqivhd7e18GWYp WOCxXQ5W7/Iw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,385,1583222400"; d="scan'208";a="463762707" Received: from dpdkxuanding-dev2.sh.intel.com ([10.67.118.152]) by fmsmga005.fm.intel.com with ESMTP; 12 May 2020 19:14:33 -0700 From: Xuan Ding To: maxime.coquelin@redhat.com, zhihong.wang@intel.com, xiaolong.ye@intel.com Cc: dev@dpdk.org, Xuan Ding , stable@dpdk.org Date: Wed, 13 May 2020 02:14:10 +0000 Message-Id: <20200513021410.98031-1-xuan.ding@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200512095155.98708-1-xuan.ding@intel.com> References: <20200512095155.98708-1-xuan.ding@intel.com> Subject: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes the situation where vhost-user cannot start as server with dequeue_zero_copy enabled. Using flag instead of vsocket->is_server to determine whether vhost-user is in client mode. Because vsocket->is_server is not ready at this time. Cc: stable@dpdk.org Signed-off-by: Xuan Ding --- v2: * Added the description of problem solved in commit log. --- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index bb8d0d780..0a66ef976 100644 --- a/lib/librte_vhost/socket.c +++ b/lib/librte_vhost/socket.c @@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags) ret = -1; goto out_mutex; } - if (!vsocket->is_server) { + if ((flags & RTE_VHOST_USER_CLIENT) != 0) { VHOST_LOG_CONFIG(ERR, "error: zero copy is incompatible with vhost client mode\n"); ret = -1; -- 2.17.1