From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1127EA034F; Wed, 13 May 2020 07:25:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6577C1C1B1; Wed, 13 May 2020 07:25:17 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4EDDF1C06D for ; Wed, 13 May 2020 07:25:16 +0200 (CEST) IronPort-SDR: ZwuVQU6nPBcKfb91dOLR5so/g6HucQ7pnbCkwoI8ZcSexAO/oVpYPVCICKmdRnYamshHM7vJHV XIqcshu91cAw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 22:25:15 -0700 IronPort-SDR: zcCvAUly7OFMmw/Gyv24WsGmOgrpZwdHE+RaQJfROOYeNONj2nUgWs77VPYSRyAxAPuDPukd4h VB/uZ9r890ig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,386,1583222400"; d="scan'208";a="463802228" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.116.183]) by fmsmga005.fm.intel.com with ESMTP; 12 May 2020 22:25:13 -0700 Date: Wed, 13 May 2020 13:17:05 +0800 From: Ye Xiaolong To: Shougang Wang Cc: dev@dpdk.org, Beilei Xing , Qiming Yang Message-ID: <20200513051705.GA90063@intel.com> References: <20200506061455.102358-1-shougangx.wang@intel.com> <20200513025450.66909-1-shougangx.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513025450.66909-1-shougangx.wang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix failing to create FDIR flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/13, Shougang Wang wrote: >This patch fixes the issue that the flow which both source MAC mask >and destination MAC mask are all zeros can not be created. > >Fixes: ea0c22fd8227 ("net/i40e: enable MAC address as flow director input set") > >Signed-off-by: Shougang Wang >Tested-by: Hailin Xu >Reviewed-by: Jeff Guo >--- > >v2 change: >- Change code alignment format >--- > drivers/net/i40e/i40e_flow.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c >index 65f877866..8ce21f7b6 100644 >--- a/drivers/net/i40e/i40e_flow.c >+++ b/drivers/net/i40e/i40e_flow.c >@@ -2643,7 +2643,8 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev, > filter->input.flow.l2_flow.src = > eth_spec->src; > input_set |= (I40E_INSET_DMAC | I40E_INSET_SMAC); >- } else { >+ } else if (!rte_is_zero_ether_addr(ð_mask->src) || >+ !rte_is_zero_ether_addr(ð_mask->dst)) { > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ITEM, > item, >-- >2.17.1 > Applied to dpdk-next-net-intel, Thanks.