From: Nithin Dabilpuram <ndabilpuram@marvell.com>
To: Ruifeng Wang <Ruifeng.Wang@arm.com>
Cc: "kirankumark@marvell.com" <kirankumark@marvell.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [EXT] RE: [PATCH] node: fix arm64 build issue for older gcc
Date: Wed, 13 May 2020 16:02:41 +0530 [thread overview]
Message-ID: <20200513103241.GA19210@outlook.office365.com> (raw)
In-Reply-To: <HE1PR0801MB2025C4AD89A5C8535FDB78A39EBF0@HE1PR0801MB2025.eurprd08.prod.outlook.com>
On Wed, May 13, 2020 at 08:51:13AM +0000, Ruifeng Wang wrote:
> External Email
>
> ----------------------------------------------------------------------
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Nithin Dabilpuram
> > Sent: Wednesday, May 13, 2020 1:48 PM
> > To: kirankumark@marvell.com; jerinj@marvell.com;
> > david.marchand@redhat.com; Nithin Dabilpuram
> > <ndabilpuram@marvell.com>; Pavan Nikhilesh <pbhagavatula@marvell.com>
> > Cc: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] node: fix arm64 build issue for older gcc
> >
> > Older GCC(~4) complains about uninitialized 'dip'
> > var though all the lanes of the vec register are set.
>
> Better to add compiler output here.
> Otherwise looks good to me.
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Ack. Will send a v2.
>
> > Hence this patch explicitly initializes vec register to fix the issue.
> >
> > Fixes: 16df6a2c6671 ("node: add IPv4 lookup for arm64")
> >
> > Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> > ---
> > lib/librte_node/ip4_lookup_neon.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/librte_node/ip4_lookup_neon.h
> > b/lib/librte_node/ip4_lookup_neon.h
> > index bb3150f..dd21cb2 100644
> > --- a/lib/librte_node/ip4_lookup_neon.h
> > +++ b/lib/librte_node/ip4_lookup_neon.h
> > @@ -45,6 +45,7 @@ ip4_lookup_node_process(struct rte_graph *graph,
> > struct rte_node *node,
> > rte_prefetch0(rte_pktmbuf_mtod_offset(pkts[i], void *,
> > sizeof(struct
> > rte_ether_hdr)));
> >
> > + dip = vdupq_n_s32(0);
> > /* Get stream for the speculated next node */
> > to_next = rte_node_next_stream_get(graph, node, next_index,
> > nb_objs);
> > while (n_left_from >= 4) {
> > --
> > 2.8.4
>
next prev parent reply other threads:[~2020-05-13 10:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 5:48 [dpdk-dev] " Nithin Dabilpuram
2020-05-13 8:51 ` Ruifeng Wang
2020-05-13 10:32 ` Nithin Dabilpuram [this message]
2020-05-13 12:06 ` [dpdk-dev] [PATCH v2] " Nithin Dabilpuram
2020-05-13 12:36 ` Jerin Jacob
2020-05-13 13:03 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513103241.GA19210@outlook.office365.com \
--to=ndabilpuram@marvell.com \
--cc=Ruifeng.Wang@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=nd@arm.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).